Git Product home page Git Product logo

Comments (7)

doowb avatar doowb commented on May 12, 2024

Nice! I think it would be pretty easy if you take a look at the other repo. If you need any help or want someone to review your code, let me know.

from gray-matter.

jonschlinkert avatar jonschlinkert commented on May 12, 2024

Nice! looks like gulp-front-matter is bsd licensed too, would be great if you were planning on MIT :-) of course, your decision..

from gray-matter.

 avatar commented on May 12, 2024

Done! Please have a look: https://github.com/jakwings/gulp-gray-matter

from gray-matter.

doowb avatar doowb commented on May 12, 2024

Looks good! I have a couple of comments:

  • I would give an option to add the context to the file object so it can be referenced in a later plugin. (e.q. rendering the file: file.content = Handlebars.compile(file.content)(file.context);)
  • You could make the handler optional by providing a default that's just a "pass-through":
this.handler = this.handler || function (data) {
  return data.original;
};

I like how you're giving the user an option to extend the front-matter context with a passed in context.

Good job!

from gray-matter.

 avatar commented on May 12, 2024

@doowb Good idea. I have open another issue on my repository: jakwings/gulp-gray-matter#1

from gray-matter.

jonschlinkert avatar jonschlinkert commented on May 12, 2024

👍

from gray-matter.

jonschlinkert avatar jonschlinkert commented on May 12, 2024

closing, if necessary we can carry on the discussion at https://github.com/jakwings/gulp-gray-matter/issues

thanks @jakwings!

from gray-matter.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.