Git Product home page Git Product logo

Comments (6)

jonschlinkert avatar jonschlinkert commented on June 17, 2024

I thought this was implemented... but I think I know what the cause is. I'll look into it. thanks

from frep.

jonschlinkert avatar jonschlinkert commented on June 17, 2024

I just added this test, it passes as-is: https://github.com/jonschlinkert/frep/blob/7047e4b7edcbdd858716c7877bba1a39349ef562/test/strings.js

If the test isn't correct, maybe you can do a pr with the failing unit test and I'll get it passing. thx

from frep.

vovayatsyuk avatar vovayatsyuk commented on June 17, 2024

Yes, you are right. It works as expected.

This issue appears when I use the gulp-frep plugin and pattern is

{
    pattern: "<comment><![CDATA[",
    replacement: ""
}

When I use the same pattern in frep itself, no errors where produced.

Stack trace:

Uncaught SyntaxError: Invalid regular expression: /<comment><![CDATA[/: Unterminated character class
      at new RegExp (<anonymous>)
      at Object.utils.buildRegexGroup (d:\www\dev\gulp-frep\node_modules\frep\lib\utils.js:27:10)
      at d:\www\dev\gulp-frep\node_modules\frep\index.js:28:27
      at Array.map (native)
      at Object.strWithArr (d:\www\dev\gulp-frep\node_modules\frep\index.js:26:41)
      at d:\www\dev\gulp-frep\test\test.js:65:38

from frep.

vovayatsyuk avatar vovayatsyuk commented on June 17, 2024

Should I create a unit test in gulp-frep repo for this issue?

from frep.

jonschlinkert avatar jonschlinkert commented on June 17, 2024

sure, that works. thanks

from frep.

vovayatsyuk avatar vovayatsyuk commented on June 17, 2024

I'm closing this issue.

It was related to old version of frep used in gulp-frep dependencies. Fixed in gulp-frep pr

from frep.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.