Tags not supported about dart_gherkin HOT 10 CLOSED

Hi @russell-sf,

Nice spot with this. I'll get it fixed up today.

from dart_gherkin.

I added some more info on what kind of gherkin is being generated by jira/xray. Its not just important for the input feature but needs to be reflected in the generated report as well. I hope you can support this.

from dart_gherkin.

@russell-sf all of the above is supported by the library (it was an obvious bug with tags on feature. The JSON reporter was done from someone else's PR so I'll go over it and make sure it is coded to spec.

from dart_gherkin.

@russell-sf I have updated the JSON reporter and fixed up the tag issue. Could you give it a try using the tags-modifications branch to see if it is what you are expecting. You can use a specific branch in your pubspec file by doing the below.

  gherkin:
    git:
      url: git://github.com/jonsamwell/dart_gherkin.git
      ref: tags-modifications

Let me know how you get on and I can get this merged into master and published

from dart_gherkin.

Hi. Thanks for the quick turnaround!

Looks good!

I am using this along with Flutter Gherkin which won't resolve with this branch. Can update Flutter Gherkin as well to update its dependency?

Thanks!

from dart_gherkin.

Hi @russell-sf

I've just created a Flutter Gherkin branch which relies on this branch. Add the below your pubspec file to test it (note that if you explicitly depend on gherkin in your pubspec not just flutter_gherkin you will need to set that to the git branch to avoid conflicts)

  flutter_gherkin:
    git:
      url: git://github.com/jonsamwell/flutter_gherkin.git
      ref: tag-and-json-report-changes

from dart_gherkin.

https://relishapp.com/cucumber/cucumber/docs/formatters/json-output-formatter#one-feature,-one-passing-scenario,-one-failing-scenario

Given

@a
Feature: Login
  User should be able to login successfully after clicking login button.

@b @c
Scenario: User logs in successfully
    Given I expect the user enters email
    And I expect the user enters password
    When user hits Login button
    Then user should land on next screen

Generates this report (notice the tags)

[ 
   { 
      "description":"",
      "id":"login",
      "keyword":"Feature",
      "line":1,
      "name":"Login",
      "uri":".\\test_driver\\features\\login.feature",
      "tags":[ 
         { 
            "line":0,
            "name":"Tags"  <<< THIS SHOULD BE "@a"
         }
      ],
      "elements":[ 
         { 
            "keyword":"Scenario",
            "type":"scenario",
            "id":"login;user logs in successfully",
            "name":"User logs in successfully",
            "description":"",
            "line":6,
            "tags":[ 
               { 
                  "line":5,
                  "name":"b"  <<< SHOULD BE "@b"
               },
               { 
                  "line":5,
                  "name":"c"   <<< SHOULD BE "@c"
               }
            ],
            "steps":[ 
               { 
                  "keyword":"Given ",
                  "name":"I expect the user enters email",
                  "line":7,
                  "match":{ 
                     "location":".\\test_driver\\features\\login.feature:7"
                  },
                  "result":{ 
                     "status":"passed",
                     "duration":4894000000,
                     "error_message":".\\test_driver\\features\\login.feature:7\nGiven I expect the user enters email\n\nInstance of 'GherkinStepNotDefinedException'"
                  }
               }
            ]
         }
      ]
   }
]

from dart_gherkin.

Hi @russell-sf

Thanks for this, I have fixed the issue with the tags, the line numbers and the way exception messages are printed.

I have updated the branch so you will need to force pub to re-install the branch in your project that uses Flutter Gherkin. The easiest way to delete the dependency and then add it again. You will know if it works as the tags will now have the '@' prefix.

If you think it is good to go I will publish the changes.

Jon

from dart_gherkin.

Hi Jon, this looks good. Reports are in correct format. Good to publish!

Thanks again for your prompt attention on this!

from dart_gherkin.

Latest version of both libraries published. Thanks for your help.

from dart_gherkin.