Adding ISRCs from a bonus CD attaches to main medium about musicbrainz-isrcsubmit HOT 5 CLOSED

I know lots of releases with "bonus DVDs", but people always added them as the second medium.

With a case like this, it basically means we can't guess the offset at all, because it could always be a blu-ray as the first disc (without a discID).

Your proposed solution is in this case not much about setting the offset beforehand, but telling isrcsubmit it shouldn't guess the offset. (and additionally providing an offset)

from musicbrainz-isrcsubmit.

Anyways, we have two solutions to the problem.

1. Never guess offsets, even for single disc releases. Which would make isrcsubmit 1 nearly unusable, of course.
   (edit: actually, we can just remove the code you quoted, that would be fine)
2. Provide an option to "not guess" the option:
   a) only --no-guess
   b) set an explicit offset (your patch)

See #47 on why I don't think providing the offset on the command line (before actually knowing how many discIDs are in the DB) might not be a good idea.

from musicbrainz-isrcsubmit.

Ad-hoc I would like the --no-guess solution best (apart from getting isrcsubmit 2 ready).

We can only hope, of course, that the blu-ray and cd have different numbers of tracks and isrsubmit fails, so the user sets the --no-guess option afterwards.
We should mention the --no-guess option at the breakage, of course.

from musicbrainz-isrcsubmit.

Actually: I'm wrong. Solution 1 might be "too strict".

We can also just remove the code you quoted. Single disc releases still have a guessed offset of 0 and it would ask for an offset in your case.

So that might be the "best solution" in this case.

If you do that, I can merge it. Include a reference to this ticket and tell why your blu-ray case makes that guess wrong.

from musicbrainz-isrcsubmit.

My pull request on #47 wasn't meant to "fix" this issue report. Even with this issue fix, #47 is still valid on the grounds of being able to feed the program the proper offsets from the initiation, thus leading to a (slightly) less interactive experience, when you have, say, a 4-disc release and you know the track offset for all of them. I do agree that it's a bit hackish though, and I'm looking forward to isrcsubmit v2. ;)

That said, I'll try out removing the block I quoted earlier... at some point. Right now I'm trying to head to bed, and my --offset has alleviated my immediate issue. :) (Now I just need someone to vote yes to removing all those ISRCs added in the first run... >_>)

from musicbrainz-isrcsubmit.