Comments (11)
Thanks, I can reproduce this on my virtual machine. (linux works fine)
The problem seems to be that on linux UTF is used in the terminal, but windows uses cp850, which is missing a lot of characters.
Not really sure how easy it is to fix.
I possibly have to ignore undisplayable characters.
from musicbrainz-isrcsubmit.
Ignore yes, for instance.
Or display as is (including garvage text) this is what isrcsubmit.exe does and mayb it’s better for release name consisting of CJK text, only non-ascii. etc.
from musicbrainz-isrcsubmit.
What do you mean with "as is"? What is the output of isrcsubmit.exe on this release? (can't fake the discId for isrcsubmit)
from musicbrainz-isrcsubmit.
I have these (basic) options:
Ascenseur pour léchafaud
(ignore)
Ascenseur pour l?échafaud
(replace)
Ascenseur pour l⁏échafaud
(xmlcharrefreplace)
Ascenseur pour l\u2019échafaud
(backslashreplace)
I will use replace
.
I won't mess with transliteration or similar and also don't want to hack the output to be a byte string. That would generate many problems later on, I guess.
from musicbrainz-isrcsubmit.
FTR, isrcsubmit.exe
displays µ│óÕïò
in place of 波動. Your replace why not. :)
from musicbrainz-isrcsubmit.
Yes, that is a byte string with a mismatching encoding (probably UTF-8 on cp850). That is what automatically happens when you print encoded text on the terminal from C.
However, Python actually tries to find and match the encoding automatically.
That being said, I can just any encoding I want, but then I would have to create a new error_handling for encode
or test every char, so I can just use that encoding for unsuitable chars.
However, output like:
Ascenseur pour lÔÇÖ+®chafaud
is much more distinguished (you can see that these are differen chars), rather than everything beeing undistinguishable "?"
Wha I really would like to get working though, is real unicode display in the cmd (should be possible).
from musicbrainz-isrcsubmit.
isrcsubmit.bat
should have unicode support now.
$ chcp
Active code page: 850
$ chcp 65001
$ isrcsubmit.py
$ chcp 850
Should also work.
Always reset th code page to something different than 65001 again afterwards.
Otherwise batchfiles and other cmd output will not work.
This is the same for isrcsubmit.bat. There is a trick in the bat to make it work at all.
Please report if you have issues with this.
from musicbrainz-isrcsubmit.
Hi Jonny ! Thanks big times, I didn’t know this tricks !
I still have an error (see below) but it should be possible to end the fix (see even lower).
DiscID: TK5efmSk3QXYTIqtVZuCGisoJDg-
Tracks on Disc: 16
Artist: Traceback (most recent call last):
File "isrcsubmit.py", line 743, in <module>
print 'Artist:\t\t', release.getArtist().getName()
LookupError: unknown encoding: cp65001
Over there they attempt to fix this bug by telling Python to make this cp65001
map to utf-8
. Maybe that works !
edit Sorry I didn’t understand I had to update my isrcsubmit.py
! :) It works like isrcsubmit.exe
now : L’Indécideur
Thanks very much ! :)
from musicbrainz-isrcsubmit.
Still not working for you?
Did you set the cmd font to Lucida Console
?
On my (virtual) machine it works like it should, meaning it does look like an apostrophe:
2: Miles Davis - Ascenseur pour l’échafaud
Or is than only a problem pasting the output of your terminal into the github comment?
from musicbrainz-isrcsubmit.
posted from my virtual windows machine (windows XP):
2: Miles Davis - Ascenseur pour l’échafaud
EDIT:
also works from a physical Windows 7 machine.
With isrcsubmit.bat I always see it as an apostrophe and with isrcsubmit.py I see ? when using standard cp850 and as apostrophe when using cp65001.
With no configuration I see it as garbage characters.
from musicbrainz-isrcsubmit.
I have windows XP and tried Lucida font. I have to get used to it now because the extended latin works with it ! :)
Thanks, Jonny ! 👍
from musicbrainz-isrcsubmit.
Related Issues (20)
- [bug] ^c does not stop script immediately
- --no-keyring still checks for DBus secrets interface HOT 2
- "ERROR: cdrdao returned with 1" and no further info HOT 5
- proxy option HOT 1
- Documented option “-h” does not display help HOT 4
- Failed install on macOS 10.12 HOT 4
- Multiple discs in single release with same TOC cause a crash
- `setup.py install` broken HOT 9
- improve installing via pip HOT 4
- Getting an error page when I try to submit to musicbrainz HOT 3
- musicbrainz-isrcsubmit slow with cdrdao HOT 1
- Could not find module 'discid.dll' HOT 3
- Release selection improvement
- --force-submit requires internet connection
- Drop support for old Python versions
- Submit ISRCs from digital music files instead of CDs
- Display release disambiguation comments
- Compatibility with new setuptools HOT 1
- Rename main branch to “main” HOT 2
- Windows: Could not find module 'discid.dll' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from musicbrainz-isrcsubmit.