Comments (8)
Cdrdao reads ISRCs from CD-Text (and my cdrdao backend uses them, if none are found in the channels).
There is a windows build available, see #24 (comment)
Wasn't mediatools supposed to read CD-Text ISRCs, too?
Anyways using isrcsubmit.exe as a backend to isrcsubmit.py should be possible somehow, but would be quite difficult. Isrcsubmit.exe want's to do stuff without asking. (First thing on my virtual machine it opens up a browser tab for an unknown discId)
from musicbrainz-isrcsubmit.
Using CDRDAO (on E:) says :/
ERROR: cdrdao can only use the default device!
mediatools is looking in q-chan, I don’t know if it’s looking in cd-text, it doesn’t seem so as I have some discs for which I have to use isrcsubmit.exe which is hopefully correct for those (hopefully very few) CDs.
from musicbrainz-isrcsubmit.
Yes, that is the cdrdao-windows problem. After printing that error it doesn't work? I might change that ERROR
to warning. If you only have on CD drive, cdrdao might still work as expected (even if the drive letter is not D).
Cdrdao expects something like 0,1,0
as device, but libdiscid expects drive letters (like E:
)
I would basically need a different device option just for cdrdao (on windows).
What does
cdrdao scanbus
give you?
What does
mediatools drive e: cdtext
give you?
Can you combine that to mediatools drive e: isrc cdtext
?
from musicbrainz-isrcsubmit.
Sorry I was very busy lately.
I’m not sure any more that this CD has the ISRC in its CD-TEXT, eventually (because Tau Analyser scans the surface and finds them progressively).
I want to try your commands to help you.
I want a way of knowing for sure where the ISRC are stored.
mediatools drive e: cdtext
mediatools drive e: isrc cdtext
gives no CD-TEXT info for instance
CDTEXT STARTS
CDTEXT ENDS
Other infos
cdrdao scanbus
says
3,0,0 : TSSTcorp, CDRWDVD TS-L463A, D300
This is a lame slim combo
cdrdao read-toc tata.txt
Finds ISRC on each tracks. example for start of disc and track 1 console :
PQ sub-channel reading (audio track) is supported, data format is BCD.
Raw P-W sub-channel reading (audio track) is supported.
Cooked R-W sub-channel reading (audio track) is supported.
Analyzing track 01 (AUDIO): start 00:00:00, length 03:38:10...
Found 14 Q sub-channels with CRC errors.
Found ISRC code.
Control nibbles of track match CD-TOC settings.
…
Then starting of tata.txt :
CD_DA
// Track 1
TRACK AUDIO
COPY
NO PRE_EMPHASIS
TWO_CHANNEL_AUDIO
ISRC "GBCEL0501180"
FILE "data.wav" 0 03:37:42
Do you know if it would have said that it found them from CD-TEXT if they were there ?
So anyway, a cdrdao
fallback seems good. Notice that I didn’t specify any drive letter nor 3,0,0
in the command…
I don’t know why mediatools.exe
doesn’t work on some CDs.
from musicbrainz-isrcsubmit.
What an idiot I am !
Actually, after displaying the cdrdao ERROR
everything works indeed !
So actually may I re-suggest differently something like :
Being able to give -b
option a list of backends instead of just one :
python isrcsubmit.py -d e: -u jesus2099 -b mediatools,cdrdao
Would first try to find ISRC
with mediatools
then, if none, with cdrdao
.
from musicbrainz-isrcsubmit.
The TOC output of CDrdao looks like in #17 when the ISRC is in the CD-TEXT.
isrcsubmit.py doesn't show you where the ISRC is located (it doesn't even take note of it)
I added another issue to defuse that ERROR message, because it seems to be misleading to the user: #38
from musicbrainz-isrcsubmit.
As for the actual proposal in this issue, setting a list of backends on the command line:
There is already a built-in list of backends to try. The fall back case is when a backend is not found at all.
The backends give the same result on the same drive (on the same platform). This is my experience.
The exception is mediatools, which has another ISRC search algorithm which is supposed give no duplicate ISRCs.
This release seems to be an exception for unknown reasons.
When there are more releases like this, we have to move mediatools down in the preference list.
The problem with a fall back mechanism on anything other than "backend not found" is complexity and time.
There are more reasons to try another backend: Duplicate ISRCs, no ISRCs, some ISRCs missing.
And we only have one release right now, which seems to be having problems with one backend. No reason to implement a general solution to an unknown problem.
Please keep me updated if you have more releases like this. I can only test different backens on linux and like I said: I never had different results with different backends at all. (only random duplicates that even change on multiple reads with the same backend)
from musicbrainz-isrcsubmit.
OK it’s pretty rare I remember only of 5 or 6.
And I can manually set the -b backend
of choice so no problem actually, let me close the ticket. :)
from musicbrainz-isrcsubmit.
Related Issues (20)
- [bug] ^c does not stop script immediately
- --no-keyring still checks for DBus secrets interface HOT 2
- "ERROR: cdrdao returned with 1" and no further info HOT 5
- proxy option HOT 1
- Documented option “-h” does not display help HOT 4
- Failed install on macOS 10.12 HOT 4
- Multiple discs in single release with same TOC cause a crash
- `setup.py install` broken HOT 9
- improve installing via pip HOT 4
- Getting an error page when I try to submit to musicbrainz HOT 3
- musicbrainz-isrcsubmit slow with cdrdao HOT 1
- Could not find module 'discid.dll' HOT 3
- Release selection improvement
- --force-submit requires internet connection
- Drop support for old Python versions
- Submit ISRCs from digital music files instead of CDs
- Display release disambiguation comments
- Compatibility with new setuptools HOT 1
- Rename main branch to “main” HOT 2
- Windows: Could not find module 'discid.dll' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from musicbrainz-isrcsubmit.