Git Product home page Git Product logo

Comments (8)

jesus2099 avatar jesus2099 commented on July 24, 2024

Wow, so cool !

from musicbrainz-isrcsubmit.

Freso avatar Freso commented on July 24, 2024

This should probably be fixed upstream though, instead of making a (relatively) lengthy work-around.

I do like the and not debug though. 👍

from musicbrainz-isrcsubmit.

JonnyJD avatar JonnyJD commented on July 24, 2024

I created an upstream report:
http://tickets.musicbrainz.org/browse/LIB-20

I doubt this will be fixed soon, though.

from musicbrainz-isrcsubmit.

JonnyJD avatar JonnyJD commented on July 24, 2024

Fixed upstream with metabrainz/libdiscid@15b4ba7

Actually this was already fixed 5 years ago, but this was only in the isrc branch.
The fix is now life with libdiscid 0.3.0

I can probably remove the hack when we have a working windows build of libdiscid 0.3.0.
http://ftp.musicbrainz.org/pub/musicbrainz/libdiscid/libdiscid-0.3.0-win32bin.zip needs MSVCR100 and I don't want to include that in my windows package.

from musicbrainz-isrcsubmit.

jesus2099 avatar jesus2099 commented on July 24, 2024

You’re right, the less files, the better. :)

from musicbrainz-isrcsubmit.

JonnyJD avatar JonnyJD commented on July 24, 2024

Could you try http://isrcsubmit.jonnyjd.net/downloads/libdiscid-0.3.0-win32.zip? That shouldn't depend on anything that's not part of the system.

If that works, I can link that everywhere and remove that weird fix again.

from musicbrainz-isrcsubmit.

jesus2099 avatar jesus2099 commented on July 24, 2024

It worked with mediatools backend. :)
I will test your new release then, because I have a global name 'saneWhich' is not defined error when I try to use cdrdao. I think my version might be a mix of various file tries and be happy to install a new clean version. :)

from musicbrainz-isrcsubmit.

JonnyJD avatar JonnyJD commented on July 24, 2024

0.5.2 is this "new clean version".

0.6 is still not done.
Potentially 0.6 will be named 1.0 and I will work on 2.0 aftewards (with NGS).

from musicbrainz-isrcsubmit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.