Git Product home page Git Product logo

Comments (11)

JonnyJD avatar JonnyJD commented on July 24, 2024
  1. Possible, yes. Should this be done everytime or just when the ID has multiple releases attached? Should the script ask to open it in the browser? Should it ask only with multiple releases?
  2. These weird device names are printed by libdiscid on Windows, so I don't have direct control. However, I can see if I can hack something.

from musicbrainz-isrcsubmit.

JonnyJD avatar JonnyJD commented on July 24, 2024

I opened issue #33 about these device strings.

from musicbrainz-isrcsubmit.

jesus2099 avatar jesus2099 commented on July 24, 2024

The URL would be displayed in any case, opening web browser only when ID not found…

DiscID:         3mGdiDepgorlStCzqPseCCh9kDg-
Tracks on Disc: 12

Would become

DiscID:         http://musicbrainz.org/cdtoc/3mGdiDepgorlStCzqPseCCh9kDg-
Tracks on Disc: 12

It’s just because I need to copy/paste isrcstuff to edit note. If it is not a welcome update for everyone, I can cope not having it…

from musicbrainz-isrcsubmit.

JonnyJD avatar JonnyJD commented on July 24, 2024

How do you include an edit note while submitting ISRCs?

from musicbrainz-isrcsubmit.

Freso avatar Freso commented on July 24, 2024

If you have "3mGdiDepgorlStCzqPseCCh9kDg-" it's easy enough to make it "http://musicbrainz.org/cdtoc/3mGdiDepgorlStCzqPseCCh9kDg-". I wouldn't be opposed to this, but I'd prefer adding a new line, e.g.:

DiscID:         3mGdiDepgorlStCzqPseCCh9kDg-
DiscID URL:     http://musicbrainz.org/cdtoc/3mGdiDepgorlStCzqPseCCh9kDg-
Tracks on Disc: 12

from musicbrainz-isrcsubmit.

JonnyJD avatar JonnyJD commented on July 24, 2024

Well, having urls in the output makes it (even more) messy.
It would be perfect if we could create an edit note with the toc url, but as far as I know, this is not possible.
You can just search for that edit in the browser and add the toc url manually, but I don't think many users would do that.

Adding verbosity levels (0=quiet, 1=norm, 2=info, .. ?=debug) would make the code more complex, but the output less of a mess for the "casual" user.

For myself I have a small showrelease.py script that will open a browser tab for the disc in the drive. @jesus2099 that might also be an option in your dos.bat.

from musicbrainz-isrcsubmit.

JonnyJD avatar JonnyJD commented on July 24, 2024

If there is a request, I could add showrelease.py in this archive. It uses libdiscid to get the discid and then open the submiturl (where you will find the toc url when the discid is already submitted). It takes the drive as a parameter.

from musicbrainz-isrcsubmit.

Freso avatar Freso commented on July 24, 2024

Heh. I have a hacked "isrcsubmit.py" with a tone of code removed called "disclookup.py" which really just opens a browser window (using the CDTOC though, and not the DiscID, IIRC). :)

Perhaps an option "--open-in-browser" or something to always open the DiscID and/or release in the browser after completion would be a good idea?

from musicbrainz-isrcsubmit.

JonnyJD avatar JonnyJD commented on July 24, 2024

submiturl opens through the TOC, yes. The discid is only linked on that page. Doesn't make much of a difference. With the submiturl you can even attach the TOC to another disc (sometimes necessary).

Another option is also an idea, but that makes the options more complicated.
--submiturl would be another idea for the option name.
That would be easiest for the user, I guess.

Have to think about that a bit. What do you think, @jesus2099 ?

from musicbrainz-isrcsubmit.

jesus2099 avatar jesus2099 commented on July 24, 2024

Well, forget my suggestion then ;)
I just need a clean output to just copy and paste in edit note including a link to DiscID, but I can go on adding it manually, it would make an ugly display indeed.
The edit note is manual btw, isrc submission does not unfortunately allow edit note nor application name.

from musicbrainz-isrcsubmit.

JonnyJD avatar JonnyJD commented on July 24, 2024

Because this shows up in Google: I uploaded my showrelease.py.

from musicbrainz-isrcsubmit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.