Comments (6)
I can verify this with setting the discID to this value (with any disc in the drive):
diff --git a/isrcsubmit.py b/isrcsubmit.py
index 2b92db7..46c406d 100755
--- a/isrcsubmit.py
+++ b/isrcsubmit.py
@@ -331,7 +331,8 @@ class Disc(object):
@property
def id(self):
- return self._disc.getId()
+ return "Rl7E4c2SbxEwLh9gwYX57V6pR6I-"
+ #return self._disc.getId()
@property
def trackCount(self):
I can also verify the problem with isrcsubmit 0.4 (setting discID to this id).
It looks like a problem in the python-musicbrainz2 library. This would be bad, because python-musicbrainz2 is deprecated and might not receive bugfixes.
The "-" at the end of the id doesn't seem to be the problem. That is quite common and i tested another disc with such an id.
from musicbrainz-isrcsubmit.
Looking it up (via Picard) shows that the release has a stub. Perhaps this is what is throwing things off? (E.g., it's finding a (stub) release but no releaseId?)
from musicbrainz-isrcsubmit.
Oh, didn't see your comment. :)
from musicbrainz-isrcsubmit.
The problem in python-musicbrainz2 is, that the musicbrainz id (!= disc id) is "None". Possibly because this is a stub.
Bare test for pymb2:
#!/usr/bin/env python2
from musicbrainz2.webservice import Query, WebService, ReleaseFilter
agent = "isrcsubmit-test"
ws = WebService(userAgent=agent)
q = Query(ws, clientId=agent)
discId_filter = ReleaseFilter(discId="Rl7E4c2SbxEwLh9gwYX57V6pR6I-")
# working id
#discId_filter = ReleaseFilter(discId="KvJdT.MxfPnKhhaa8STa2MhBoWk-")
results = q.getReleases(filter=discId_filter)
release = results[0].release
print release.getArtist().getName(),
print "-", release.getTitle(),
#print "(" + release.getTypes()[1].rpartition('#')[2] + ")"
print "(" + ", ".join(release.getTypes()) + ")"
print "id: ", release.getId()
# this is the part that will error out
results = q.getReleaseById(release.getId())
from musicbrainz-isrcsubmit.
Oh boy..
After writing the bare test for pymb2 I relize, that I can just check for release.getId() is not None
in my script..
from musicbrainz-isrcsubmit.
Stubs are now ignored (since they are no "real" musicbrainz releases), but I show some information about the stub with d8f8c3c.
Thanks for the report.
from musicbrainz-isrcsubmit.
Related Issues (20)
- [bug] ^c does not stop script immediately
- --no-keyring still checks for DBus secrets interface HOT 2
- "ERROR: cdrdao returned with 1" and no further info HOT 5
- proxy option HOT 1
- Documented option β-hβ does not display help HOT 4
- Failed install on macOS 10.12 HOT 4
- Multiple discs in single release with same TOC cause a crash
- `setup.py install` broken HOT 9
- improve installing via pip HOT 4
- Getting an error page when I try to submit to musicbrainz HOT 3
- musicbrainz-isrcsubmit slow with cdrdao HOT 1
- Could not find module 'discid.dll' HOT 3
- Release selection improvement
- --force-submit requires internet connection
- Drop support for old Python versions
- Submit ISRCs from digital music files instead of CDs
- Display release disambiguation comments
- Compatibility with new setuptools HOT 1
- Rename main branch to βmainβ HOT 2
- Windows: Could not find module 'discid.dll' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from musicbrainz-isrcsubmit.