Comments (7)
I was able to fix it with this change:
--- isrcsubmit.py 2012-08-29 14:08:03.000000000 +0200
+++ isrcsubmit_mod_f_cdtext.py 2012-08-29 16:17:09.000000000 +0200
@@ -313,7 +313,7 @@
with open(tmpfile, "r") as toc:
for line in toc:
words = line.split()
- if len(words) > 0:
+ if not line.startswith(" ") and len(words) > 0:
if words[0] == "//":
trackNumber = int(words[2])
elif words[0] == "ISRC":
Note that this is the very first time I “develop” in Python and I found out about the syntax by looking around in the script, so it’s certainly not optimal. (Why first split the line, then test whether to ignore it?)
from musicbrainz-isrcsubmit.
Sorry, I must have overlooked this issue/notification mail.
Thank you for the contribution.
Now there is also pull request #18 and I received a patch per email.
I will fix it quite soon.
from musicbrainz-isrcsubmit.
Heh. I need to remember to check issues on GitHub. :)
Anyway, AFAICT, the proposed edit here simply ignores ISRCs stored in CD-TEXT. If there is a CD which doesn't use the "ISRC" field on its own but stores it in CD-TEXT->ISRC, this code change would prevent it from being used. My pull request just makes it disregard assigning ISRCs to trackNumber None. JonnyJD knows the code best though, so whatever he decides is the right way to fix it, I'll trust that decision.
from musicbrainz-isrcsubmit.
Jim Patterson sent me another case with ISRC in CD-Text, but with hyphens.
http://musicbrainz.org/release/3e0b924d-ccaa-46f1-a29b-94fab98f4f4c
// Track 1
TRACK AUDIO
NO COPY
NO PRE_EMPHASIS
TWO_CHANNEL_AUDIO
ISRC "USSM19806736"
CD_TEXT {
LANGUAGE 0 {
TITLE "Ready To Run"
PERFORMER "DIXIE CHICKS"
DISC_ID ""
ISRC "US-SM1-98-06736"
}
}
FILE "data.wav" 0 03:52:40
// Track 2
TRACK AUDIO
NO COPY
NO PRE_EMPHASIS
TWO_CHANNEL_AUDIO
ISRC "USSM19901547"
CD_TEXT {
LANGUAGE 0 {
TITLE "If I Fall You're Going Down With Me"
PERFORMER "DIXIE CHICKS"
DISC_ID ""
ISRC "US-SM1-99-01547"
}
}
FILE "data.wav" 03:52:40 03:05:02
from musicbrainz-isrcsubmit.
Even more important: Track 13 on the same disc has an ISRC given only in CD-Text, but is not found "the normal way".
// Track 13
TRACK AUDIO
NO COPY
NO PRE_EMPHASIS
TWO_CHANNEL_AUDIO
CD_TEXT {
LANGUAGE 0 {
TITLE "Ain't No Thang But A Chickin' Wang"
PERFORMER "DIXIE CHICKS"
ISRC "US-SM1-99-07390"
}
}
FILE "data.wav" 44:54:67 00:06:00
from musicbrainz-isrcsubmit.
I've added a fix for the hyphens to my pull request. (Not tested though, so please do to make sure it actually works. :p)
And the case about the ISRC should be handled fine by my cahnge too, unlike the code in comment #1. In the pull request, it should just add the ISRC in the CD-TEXT to the trackNumber without any issue.
from musicbrainz-isrcsubmit.
Please tell me if there are still issues after my octupus merge.
from musicbrainz-isrcsubmit.
Related Issues (20)
- [bug] ^c does not stop script immediately
- --no-keyring still checks for DBus secrets interface HOT 2
- "ERROR: cdrdao returned with 1" and no further info HOT 5
- proxy option HOT 1
- Documented option “-h” does not display help HOT 4
- Failed install on macOS 10.12 HOT 4
- Multiple discs in single release with same TOC cause a crash
- `setup.py install` broken HOT 9
- improve installing via pip HOT 4
- Getting an error page when I try to submit to musicbrainz HOT 3
- musicbrainz-isrcsubmit slow with cdrdao HOT 1
- Could not find module 'discid.dll' HOT 3
- Release selection improvement
- --force-submit requires internet connection
- Drop support for old Python versions
- Submit ISRCs from digital music files instead of CDs
- Display release disambiguation comments
- Compatibility with new setuptools HOT 1
- Rename main branch to “main” HOT 2
- Windows: Could not find module 'discid.dll' HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from musicbrainz-isrcsubmit.