Git Product home page Git Product logo

Comments (4)

JonnyJD avatar JonnyJD commented on July 4, 2024

Yes, the script is still using the old API. A new version is planned. However, that shouldn't be a big problem in many cases and also not this one.

My first guess would be, that the script thinks it is a single disc release, because there is only one Disc ID given. There is no ID for the DVD.

I will probably do that offset-guessing part also in this case, later this day.

Thanks for reporting.

from musicbrainz-isrcsubmit.

JonnyJD avatar JonnyJD commented on July 4, 2024

I reworked the workaround a bit.

The problem in this case is having a bonus DVD (that can't have a disc ID). The Workaround to detect multiple releases in the old API with NGS works with Disc IDs.
And it's not that the old API couldn't handle multiple disc releases. It just that the old API never got fixed for NGS ;--)

Please try if this isrcsubmit.py does what you want.
I will release a version 0.4.1.

PS:
Of course this is only a workaround and this script should use the new API. However, I didn't have time for that yet and guessing track offsets, based on DiscIDs given, works quite well for most cases (releases with 1 or 2 CDs, 1 disc ID each). Few people actually come across the part where they have to give an offset.

Progress in that direction is also affected by python-musicbrainz-ngs, especially the libdiscid support, having a stable/complete api and the question if that shouldn't be renamed to python-musicbrainz3..

from musicbrainz-isrcsubmit.

foolip avatar foolip commented on July 4, 2024

Yep, that works:

$ ./isrcsubmit.py foolip
isrcsubmit 0.4.1 by JonnyJD for MusicBrainz

using python-musicbrainz2 0.7.4
using Cdrdao 1.2.3

Please input your Musicbrainz password
Password:

DiscID: PC5dKsHXfLSTtLUNUgecT68qGBI-
Tracks on Disc: 11
Artist: 陳奕迅
Release: 上五樓的快活
Tracks in Release: 15

WARNING: Multi-disc-release given by web service.
See 'isrcsubmit.py -h' for help
Track count mismatch!
There are 11 tracks on the disc,
but 15 tracks
given for just one DiscID.

There might be multiple disc IDs per disc or none,
so the number of actual discs could be lower or even higher.

This is disc (ID) 1 of 1
This release probably has a bonus DVD without a discID.
Guessing track offset as 0

HKUM70900528 is already attached to track 2
HKUM70900529 is already attached to track 3
HKUM70900530 is already attached to track 4
HKUM70900560 is already attached to track 5
HKUM70900532 is already attached to track 6
HKUM70900533 is already attached to track 7
HKUM70900534 is already attached to track 8
HKUM70900535 is already attached to track 9
HKUM70900536 is already attached to track 10
HKUM70900561 is already attached to track 11

No new ISRCs could be found.

from musicbrainz-isrcsubmit.

JonnyJD avatar JonnyJD commented on July 4, 2024

Thanks. Released as 0.4.1.

from musicbrainz-isrcsubmit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.