Git Product home page Git Product logo

Comments (5)

jondot avatar jondot commented on August 20, 2024

Great catch!
There is a semantic issue here - would '0' be correct at this case?, it is a proper, valid value (e.g. in the case of a dashboard reporting 0 errors, it would lie to me because the first error is that i'm not getting any value from Graphite :).
I personally am leaning towards '-' or not display a value at all. Any thoughts?

from graphene.

sigil66 avatar sigil66 commented on August 20, 2024

I would tend to agree, but it would be GREAT to be able to define the label for null data event. So if I wanted '0' or perhaps 'NA'. In a pinch '-' would be better than bombing on the type error ;)

from graphene.

jondot avatar jondot commented on August 20, 2024

Agreed, I'll push a fix today / tomorrow.

from graphene.

sigil66 avatar sigil66 commented on August 20, 2024

More info, here is the returned JSON that generated the error:

[{"target": "hitcount(api.access.count, "1min")", "datapoints": [[null, 1330444120], [null, 1330444180], [null, 1330444240], [null, 1330444300], [null, 1330444360], [null, 1330444420], [null, 1330444480], [null, 1330444540], [null, 1330444600], [null, 1330444660], [null, 1330444720], [null, 1330444780], [null, 1330444840], [null, 1330444900], [null, 1330444960], [null, 1330445020], [null, 1330445080], [null, 1330445140], [null, 1330445200], [null, 1330445260], [null, 1330445320], [null, 1330445380], [null, 1330445440], [null, 1330445500], [null, 1330445560], [null, 1330445620], [null, 1330445680], [null, 1330445740], [null, 1330445800], [null, 1330445860], [null, 1330445920], [null, 1330445980], [null, 1330446040], [null, 1330446100], [null, 1330446160], [null, 1330446220], [null, 1330446280], [null, 1330446340], [null, 1330446400], [null, 1330446460], [null, 1330446520], [null, 1330446580], [null, 1330446640], [null, 1330446700], [null, 1330446760], [null, 1330446820], [null, 1330446880], [null, 1330446940], [null, 1330447000], [null, 1330447060], [null, 1330447120], [null, 1330447180], [null, 1330447240], [null, 1330447300], [null, 1330447360], [null, 1330447420], [null, 1330447480], [null, 1330447540], [null, 1330447600], [null, 1330447660]]}]

from graphene.

sigil66 avatar sigil66 commented on August 20, 2024

Tested the fix, resolves my use case!

from graphene.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.