Comply to NC 18+ about sharerenamer HOT 124 CLOSED

No offense taken. 😃

Will try to supply a patch soon.

from sharerenamer.

It looks like i am going to continue the development of this App :) #29

I will be able to start developing in a few weeks (maybe sooner).

from sharerenamer.

I'm working on it, but I'm struggling a but with vue.

from sharerenamer.

For this app to work again, we need an extension of the NC API.
I'll try to contact the core developers.

from sharerenamer.

Update:
It will take longer as expected, because on NC 18 there are only limited possibilities to extend the details/share menu. I think that I'll need an extension of NC's API first. I'm already in contact with the NC devs.

from sharerenamer.

For this app to work again, we need an extension of the NC API.
I'll try to contact the core developers.

They are focused on the upcoming release of NC 19, so this will still last a while.
Sorry...

And after this they will be focused on NC 20, and so on.

Unfortunately NC17 will eventually go EOL, and we will be left with no choice but to either keep outdated software, or upgrade and lose this awesome add-on that you have made.

I think we should make our voices heard, how about starting a petition to request support from the Core team? I am sure this would be signed by a lot of people!

from sharerenamer.

It would be great if it were made compatible with NC18!

from sharerenamer.

I started the PR #31 to this repository, where i will implement the rewrite.
I hope i will be able to get a working version of the rewrite within the next 2 weeks.

from sharerenamer.

Well, this is getting a bit off topic right now.
First of all I have to focus on making this app compatible to NC 18.

Please open another issue about that app "becoming official" after it's available on NC 18.

from sharerenamer.

That is sad to hear. Unfortunately, I cannot contribute with any PRs.

Sincerely, I do not understand why this app isn't part of the official release.

from sharerenamer.

But the use of the app can lead to a security risk (links might be guessable).

Wait, seriously? You're saying someone actually considers random links a "security feature"?

from sharerenamer.

Yes, it cannot work as the whole share UI was redesigned in NC 18.
Unfortunately, I cannot tell you when I can provide an update of the app.

Any PRs are welcome. 😄

from sharerenamer.

Very useful app. I hope that it is made compatible with NC18 soon.

from sharerenamer.

The question isn't when will this be done?

The question is what can we do to help to make this happen?

@DecaTec ^^^ it was not meant as a rethorical question ;)

from sharerenamer.

Unfortunately not. If NC's API isn't expanded, I guess that I have to drop support for this app.
I'm really sorry to say that.

from sharerenamer.

Here is ugly low level solution for all you admins out there.

I "renamed" share token for id=2:

MariaDB [nc19rc2]> SELECT * FROM oc_share WHERE id=2\G
*************************** 1. row ***************************
              id: 2
      share_type: 3
      share_with: NULL
        password: NULL
       uid_owner: nxcladmin
   uid_initiator: nxcladmin
          parent: NULL
       item_type: folder
     item_source: 989
     item_target: NULL
     file_source: 989
     file_target: /Shared/public
     permissions: 1
           stime: 1589889769
        accepted: 0
      expiration: 2020-06-01 00:00:00
           token: 6NnTBDCdZnj5wRG
       mail_send: 0
      share_name: NULL
password_by_talk: 0
            note: ohai :)
   hide_download: 0
           label:
1 row in set (0.000 sec)

Update token field and voila :)

MariaDB [nc19rc2]> UPDATE oc_share SET token='myPublicShare' WHERE id=2;
Query OK, 1 row affected (0.001 sec)
Rows matched: 1  Changed: 1  Warnings: 0

MariaDB [nc19rc2]> SELECT * FROM oc_share WHERE id=2\G
*************************** 1. row ***************************
              id: 2
      share_type: 3
      share_with: NULL
        password: NULL
       uid_owner: nxcladmin
   uid_initiator: nxcladmin
          parent: NULL
       item_type: folder
     item_source: 989
     item_target: NULL
     file_source: 989
     file_target: /Shared/public
     permissions: 1
           stime: 1589889769
        accepted: 0
      expiration: 2020-06-01 00:00:00
           token: myPublicShare
       mail_send: 0
      share_name: NULL
password_by_talk: 0
            note: ohai :)
   hide_download: 0
           label:
1 row in set (0.000 sec)

from sharerenamer.

Thank you for the work on sharerenamer @DecaTec. I am waiting with upgrading to Nextcloud18 until there is an update for sharerenamer because it is indispensable for me. The security reasons about sharerenamer (random links = security feature) are not comprehensible, because the data (sharenames) are also random for strangers. If anyone would like more security it is not prohibited to add a secure password.

from sharerenamer.

Thanks for your decision, it's clear now what (not) to expect.
I can fully understand that life goes on and focus change.
THANK YOU for what you did so far and all the best for you.

@nextcloud devs: This App should be a core function, not an app, really.

from sharerenamer.

This was already suggested several times.
But the use of the app can lead to a security risk (links might be guessable). Due to this fact, this app will never become "official".

from sharerenamer.

It won't help if everybody writes the same. Github has a reaction feature. Please use it and give +1 to views that you share instead of writing the same with different words. Thanks.

from sharerenamer.

Just tried to enable it anyway on nc18 and it does not work.

from sharerenamer.

Thank you @DecaTec !

from sharerenamer.

For this app to work again, we need an extension of the NC API.
I'll try to contact the core developers.

They are focused on the upcoming release of NC 19, so this will still last a while.
Sorry...

from sharerenamer.

@julpec Please use GitHub reactions like everyone else the next time. Everyone subscribed got an notification for your +1 post.

from sharerenamer.

I assume that nothing more will come here !?

from sharerenamer.

Well i would predict, that i can continue the work in about a week.
If somebody wants to help he can obviously do that. The majority of the work is already done in the v3 branch, so getting it done should not take long.

from sharerenamer.

Incredibly useful app extension. I also agree that NC should include this as a default! I am considering reverting my entire NC setup back to 17 purely for this function...

from sharerenamer.

This app is gold, thank you @DecaTec for your effort!

from sharerenamer.

Yes, I confirm superb words from other users and waiting for new version of plugin for NC 18 too.

from sharerenamer.

There is now an api which makes it possible to inject entries into the share dropdown:
nextcloud/server#28835
It will be available in NC23 and NC22.2.0

from sharerenamer.

Incredibly useful app extension. I also agree that NC should include this as a default! I am considering reverting my entire NC setup back to 17 purely for this function...

I'm really grateful that previously renamed shares still work in 18 (like my one-way upload folder and some installers that I always send to clients). DecaTec, I can't help with a PR, but thanks for continuing to work on it. I miss this functionality in NC every day since 18!

from sharerenamer.

I have to agree with @cptMikky.
Although it is "harder" to guess a random link, this is in no way a security feature, and should in no way be seen as such.
For all practical purposes a random generated link should be treated the same as a custom named link.
If you need protection, that's what the password protection is for (and the password policy enforcer).

If one opens a issue to re-discuss the integration of this app to nextcloud, give me a heads up to cast my vote.

from sharerenamer.

Will this ever be made to work with v18?

from sharerenamer.

Sadly, I cannot maintain this project any further.
I don't have the time to make the app compatible to Nextcloud 18+ as it probably will need some changes in Nextcloud's core code.

I'm sorry that you all waited so long for an update which will probably never come.

This way, I'm looking for a new maintainer, see #29.

from sharerenamer.

I've just noticed that my previous comment came across a bit harsh.. That was not my intention. I cannot contribute, because I do not know how to code, I'm an English teacher.

Thank you for your work! I hope you find time to patch the app soon :)

from sharerenamer.

Yes, I really miss this feature too ! Should be official for sure !
Thanks a lot for this, and I hope to use it again soon !

from sharerenamer.

I don't think that would be desirable @szaimen There are use case in which using a password is not needed or desired. I believe it should remain up to the admin to decide.

from sharerenamer.

I don't think that would be desirable @szaimen There are use case in which using a password is not needed or desired. I believe it should remain up to the admin to decide.

I think what he's implying is that by adding the option for password protection, it might get it past the Nextcloud gatekeepers. However, that functionality was already in the past versions. I agree, though, I certainly don't want mandatory password protection with renamed links. I've always used it for things like sending someone service files, like https://nc.example.com/s/Teamviewer so it's clear what it is and easy for me to remember and just write in an e-mail without going back to the server to copy the link.

No, I just wanted to suggest the option to add a configurable share-setting to the admin settings, where the admin can decide what happens with shares that got renamed. I imagine 3 options:

1. Enforce password protection
2. Always ask for a password
3. Disable password protection

I think that this feature would allow the nextcloud team to make this app official.

from sharerenamer.

I appreciate so much this app, I use everyday and with NC v18 it does not work. So I cheer developers to make the change as soon as they could.

from sharerenamer.

@DecaTec Maybe @kesselb can help you a bit getting this app back to work?

from sharerenamer.

@GlenHuf

Well, this is getting a bit off topic right now.
First of all I have to focus on making this app compatible to NC 18.

Please open another issue about that app "becoming official" after it's available on NC 18.

from sharerenamer.

Any news on this plugin?

from sharerenamer.

Thank you for your work, this is an absolutely vital extension. Fortunately, I saw this before updating Nextcloud, so now I'm waiting for a compatible version before updating from 17.x to 18.x.

from sharerenamer.

I don't think that would be desirable @szaimen There are use case in which using a password is not needed or desired. I believe it should remain up to the admin to decide.

I think what he's implying is that by adding the option for password protection, it might get it past the Nextcloud gatekeepers. However, that functionality was already in the past versions. I agree, though, I certainly don't want mandatory password protection with renamed links. I've always used it for things like sending someone service files, like https://nc.example.com/s/Teamviewer so it's clear what it is and easy for me to remember and just write in an e-mail without going back to the server to copy the link.

from sharerenamer.

E.g. what if you rename your share to just
https://nc.example.com/s/a
Then it is definitely much less secure than a random share.

Yeah, and it should be seen exactly as insecure as https://nc.example.com/s/eFmaPRpTsoYJLD3
If you want to share something that needs to be secure, you add a password protection.
Simple as that.
Edit: Security by obscurity is no security.

from sharerenamer.

If it would help. I should had no problem If you may need to add a named Link to the already existing one eg.: create nextcloud/s/{ID} and than add a second link to something like
nextcloud/NAMED/{MyNamedLink}

from sharerenamer.

Not yet. I am currently in grade 12 (wich is the last one in germany) and have to focus on school for a bit. But its quite high on my priority list :)

from sharerenamer.

No problem.
I will write a german test tomorrow and a astrophysics test next week. After that there are holidays, but i can't promise i have time then (there are 5 other tests immediately after the holidays).

from sharerenamer.

I made a quick tutorial video on how to do this in sql for someone on reddit a while back if anyone is interested.
https://www.youtube.com/watch?v=UaMzAuXvmuk

from sharerenamer.

We also use the app very often. Thank you for your efforts.

from sharerenamer.

If there are api changes required to make that feature work again open a issue at nextcloud/server and describe that changes. I think bounties are enabled at nextcloud/server.

from sharerenamer.

I'd recommend a Webserver redirect to the (generated) share link. That way, no db fiddling, plus links get even shorter, e.g.
https://yourdomain.com/shorturl → https://cloud.yourdomain.com/s/generatedrandom

from sharerenamer.

@DecaTec We need this feature on NC 21. My team and I have time to help with the development.

• Where did you manage to get with the development?
• What is missing in NC API to finish the work?
• Did you get feedback from NC team?

from sharerenamer.

YES Is Very useful plugin my users need it! And I wait new version.

from sharerenamer.

it would be great if it worked for 18 too. Thanks for your great work

from sharerenamer.

Would be very grateful too. Want to update my NC to v18, but I have many shares with customized URL.

from sharerenamer.

Sorry, no update so far.

@civita OK, that may work, but it's cumbersome and only a workaround. That's not the way it is intended to be,

Yes I know, just shared what I found accidentally. I used sharerenamer very often (both rename and duplicate links), and thank you for the maintenance. Hope it will work properly in NC 18 soon!

from sharerenamer.

Hello
I tried to make a (ugly) patch to owncloud 5 or 6 years ago because this feature is really essential especially when working in education: giving a link by writing on the board is so simple and rational!
I have installed a Nextcloud instance in my high school but I always hoped to have this feature so that my colleagues could take advantage of it. I hope that this apps will quickly become an official apps.
Thanks for this work, it's great!

from sharerenamer.

@angerized +1 !

from sharerenamer.

some news?

from sharerenamer.

If you want custom links NOW, just go to your Database (used for Nextcloud), e.g. with phpMyAdmin, and then search for "oc_share". In oc_share, you see all the active sharing links, like their destination, their creator, and their creation date, etc.
Now just look up the link you want to change the ending of, and just change the value in the "token" column to whatever you'd like.
If you changed it to e.g. testtest, you can now access the shared file via https://yourdomain.com/nextcloud/index.php/s/testtest

Of course a bit of work and completely inefficient, but better than nothing.

from sharerenamer.

Is there a way to support the idea of including the app into Nextcloud?
And, more importantly, would you be interested in doing so @DecaTec ?

from sharerenamer.

Sorry, no update so far.

@civita OK, that may work, but it's cumbersome and only a workaround. That's not the way it is intended to be,

from sharerenamer.

In the meantime, an option to some of us might be a light and open-source link shortener server like Polr
Edit: There is also a nice list putting together more self-hostable url-shortening services

from sharerenamer.

no. just id is a primary key.

> show create table oc_share \G
*************************** 1. row ***************************
       Table: oc_share
Create Table: CREATE TABLE `oc_share` (
  `id` bigint(20) NOT NULL AUTO_INCREMENT,
  `share_type` smallint(6) NOT NULL DEFAULT 0,
  `share_with` varchar(255) COLLATE utf8mb4_bin DEFAULT NULL,
  `uid_owner` varchar(64) COLLATE utf8mb4_bin NOT NULL DEFAULT '',
  `uid_initiator` varchar(64) COLLATE utf8mb4_bin DEFAULT NULL,
  `parent` bigint(20) DEFAULT NULL,
  `item_type` varchar(64) COLLATE utf8mb4_bin NOT NULL DEFAULT '',
  `item_source` varchar(255) COLLATE utf8mb4_bin DEFAULT NULL,
  `item_target` varchar(255) COLLATE utf8mb4_bin DEFAULT NULL,
  `file_source` bigint(20) DEFAULT NULL,
  `file_target` varchar(512) COLLATE utf8mb4_bin DEFAULT NULL,
  `permissions` smallint(6) NOT NULL DEFAULT 0,
  `stime` bigint(20) NOT NULL DEFAULT 0,
  `accepted` smallint(6) NOT NULL DEFAULT 0,
  `expiration` datetime DEFAULT NULL,
  `token` varchar(32) COLLATE utf8mb4_bin DEFAULT NULL,
  `mail_send` smallint(6) NOT NULL DEFAULT 0,
  `password` varchar(255) COLLATE utf8mb4_bin DEFAULT NULL,
  `share_name` varchar(64) COLLATE utf8mb4_bin DEFAULT NULL,
  `password_by_talk` tinyint(1) NOT NULL DEFAULT 0,
  `note` longtext COLLATE utf8mb4_bin DEFAULT NULL,
  `hide_download` smallint(6) NOT NULL DEFAULT 0,
  `label` varchar(255) COLLATE utf8mb4_bin DEFAULT NULL,
  PRIMARY KEY (`id`),
  KEY `item_share_type_index` (`item_type`,`share_type`),
  KEY `file_source_index` (`file_source`),
  KEY `token_index` (`token`),
  KEY `share_with_index` (`share_with`),
  KEY `parent_index` (`parent`),
  KEY `owner_index` (`uid_owner`),
  KEY `initiator_index` (`uid_initiator`)
) ENGINE=InnoDB AUTO_INCREMENT=1 DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_bin ROW_FORMAT=COMPRESSED

from sharerenamer.

May someon add this to:
https://help.nextcloud.com/t/nextcloud-deck-social-and-forms-were-listening-to-your-thoughts-and-feature-wishes/82914/1

from sharerenamer.

This plugin is the main reason holding me back to version 17.

You know that NC17 is eol since over half a year?

from sharerenamer.

Well, @JonathanTreffler your last contribution was October 2020 and your last message doesn't soon too optimistic about doing it quickly, so personally I'm all for @gaellafond and his team taking up the torch :)

from sharerenamer.

@DecaTec I mean imho it could become "official" if you would be able to force password protection if a URL is changed with the sharerenamer... (maybe force password protection should also be the default setting if you use the sharerenamer?)

from sharerenamer.

What I was mentioning before is that Password protection already worked with renamed links in the past, it doesn't need to be duplicated in the renamer.

from sharerenamer.

Any update @DecaTec ?

from sharerenamer.

I found that I am able to rename the link via Gallery app by chance. It just worked and replaced the old link when I copied the shared link in file app. Not sure this information helps or not. By the way, I added Gallery app in NC 18 by following this thread.

from sharerenamer.

There are a ton of official apps not to include this one by default. Security risk is non-existant. Maybe the link could be guessed, who cares, Maybe add an easy way to list all shares in one place in admin settings. Problem solved. Nextcloud's main purpose is to share files, it's just common sense to be able to customize the share. Some official apps have more security risk than sharerenamer. Depends how you use the tools you have.

from sharerenamer.

Hello, first thank you for this great app. Do you have an ETA on latest release compability? Even a rough estimate would do.

Thanks again.

from sharerenamer.

For this app to work again, we need an extension of the NC API.
I'll try to contact the core developers.

They are focused on the upcoming release of NC 19, so this will still last a while.
Sorry...

And after this they will be focused on NC 20, and so on.

Unfortunately NC17 will eventually go EOL, and we will be left with no choice but to either keep outdated software, or upgrade and lose this awesome add-on that you have made.

I think we should make our voices heard, how about starting a petition to request support from the Core team? I am sure this would be signed by a lot of people!

Are you going to create the petition? Or we should wait a bit after v19 release?

Keep us update, please! Its a great idea

from sharerenamer.

Does the oc_share table have a constraint for unique tokens?

from sharerenamer.

What's with the Idea #21 (comment) ?

from sharerenamer.

Any chance to get this solved soon? ^__^

from sharerenamer.

What I was mentioning before is that Password protection already worked with renamed links in the past, it doesn't need to be duplicated in the renamer.

But I really think that there should be a different setting to "normal" links.
E.g. what if you rename your share to just
https://nc.example.com/s/a
Then it is definitely much less secure than a random share.

from sharerenamer.

Yeah, and it should be seen exactly as insecure as https://nc.example.com/s/eFmaPRpTsoYJLD3
If you want to share something that needs to be secure, you add a password protection.
Simple as that.
Edit: Security by obscurity is no security.

What is @DecaTec's opinion on that?

Or where comes the statement from that this app makes the shared links insecure because the links could be guessable?

from sharerenamer.

@DecaTec Maybe you should accept something like Bountysource for your repository so some developer has an incentive to start work on this issue.

from sharerenamer.

Please, do! That would be great!

from sharerenamer.

Don't know if it would be useful, but I would sign it for sure if there's a chance it makes it happen.

But doesn't opening an issue on the NC repository is a better way? Is there one already?

from sharerenamer.

So if you have duplicated tokens, what happens? 💣

from sharerenamer.

Share with lower id gets served. But did sharerenamer check for duplicate tokens before? If not then oc_share.token must be set to UNIQUE to avoid stupidity. But then again how does nextcloud share link generator avoid duplicates?

from sharerenamer.

It checks for duplicates
https://github.com/DecaTec/sharerenamer/blob/master/db/sharerenamermapper.php#L14

from sharerenamer.

Great idea :)

from sharerenamer.

If you like to use share renamer to repair a lost linkdestination, this Idea would not help. I remembered I used this on two Links. May other use it too this way.

from sharerenamer.

That's great news!!

from sharerenamer.

Here is ugly low level solution for all you admins out there.

I "renamed" share token for id=2:

MariaDB [nc19rc2]> SELECT * FROM oc_share WHERE id=2\G
*************************** 1. row ***************************
              id: 2
      share_type: 3
      share_with: NULL
        password: NULL
       uid_owner: nxcladmin
   uid_initiator: nxcladmin
          parent: NULL
       item_type: folder
     item_source: 989
     item_target: NULL
     file_source: 989
     file_target: /Shared/public
     permissions: 1
           stime: 1589889769
        accepted: 0
      expiration: 2020-06-01 00:00:00
           token: 6NnTBDCdZnj5wRG
       mail_send: 0
      share_name: NULL
password_by_talk: 0
            note: ohai :)
   hide_download: 0
           label:
1 row in set (0.000 sec)

Update token field and voila :)

MariaDB [nc19rc2]> UPDATE oc_share SET token='myPublicShare' WHERE id=2;
Query OK, 1 row affected (0.001 sec)
Rows matched: 1  Changed: 1  Warnings: 0

MariaDB [nc19rc2]> SELECT * FROM oc_share WHERE id=2\G
*************************** 1. row ***************************
              id: 2
      share_type: 3
      share_with: NULL
        password: NULL
       uid_owner: nxcladmin
   uid_initiator: nxcladmin
          parent: NULL
       item_type: folder
     item_source: 989
     item_target: NULL
     file_source: 989
     file_target: /Shared/public
     permissions: 1
           stime: 1589889769
        accepted: 0
      expiration: 2020-06-01 00:00:00
           token: myPublicShare
       mail_send: 0
      share_name: NULL
password_by_talk: 0
            note: ohai :)
   hide_download: 0
           label:
1 row in set (0.000 sec)

Thanks for this. I'm using postgres but the process is basically the same. Things are much prettier now! Sure, I have to do it manually for share links, but it only takes a second. Very good workaround until the UI gets added.

from sharerenamer.

hello any news?

from sharerenamer.

Hey @JonathanTreffler
Sorry to ask the same question again.
Do you have a rough guess when you have time to look into this project?
With release of Nextcloud 17.0.10
https://nextcloud.com/changelog/#latest17
and the note: this is the final 17 release.
it is not a good idea to stay on version 17.

edit: Found the Answere here:
#29 (comment)

from sharerenamer.

If you want custom links NOW, just go to your Database (used for Nextcloud), e.g. with phpMyAdmin, and then search for "oc_share". In oc_share, you see all the active sharing links, like their destination, their creator, and their creation date, etc.
Now just look up the link you want to change the ending of, and just change the value in the "token" column to whatever you'd like.
If you changed it to e.g. testtest, you can now access the shared file via https://yourdomain.com/nextcloud/index.php/s/testtest

Of course a bit of work and completely inefficient, but better than nothing.

And why this can not be automated like did DecaTec?

from sharerenamer.

This plugin is the main reason holding me back to version 17. Hoping someday it will be supported for current NC versions :)

from sharerenamer.

@gaellafond Unfortunately, I cannot maintain the app any further.
But maybe a new maintainer was found.
@JonathanTreffler Are you still planning to rewrite/maintain the app in the future?

from sharerenamer.

@DecaTec Thanks for the quick response. I'm about to check-out the source and try to understand it. I'm new to NextCloud but I have many years of experience in programming. I have hope that I can fix it.

I can see there is a "Nextcloud-18" branch and a "v3" branch. Do you remember which of those branch contains the most recent development? I was thinking of looking at "Nextcloud-18" first.

from sharerenamer.

I think "v3" is the rewrite of @JonathanTreffler
But I don't know if it was just a try or if there was addes something woth to build on.

As a hint: The app (as it is) fiddles around with the DOM with JS. This cannot be done anymore, because NC changed the UI to vue.js. So probably, you have to write a whole new vue component extending the "details pane" in NC.

from sharerenamer.

@DecaTec Thanks, I understand the issue now. I have good experience with JS but I have never used Vue. I will wait to see what @JonathanTreffler have to say.

from sharerenamer.

I plan to continue my pr and my Abitur (equivalent to final exam of high school in germany) is done, but i broke my foot and cannot currently work productively. I have a lot of projects, and while this is not the my top priority it is quite high on my todo list :)
Sorry for the delay.

from sharerenamer.

As a hint: The app (as it is) fiddles around with the DOM with JS. This cannot be done anymore, because NC changed the UI to vue.js. So probably, you have to write a whole new vue component extending the "details pane" in NC.

Exactly, thats what i plan to do in the v3 rewrite.

from sharerenamer.