Git Product home page Git Product logo

Comments (2)

svpernova09 avatar svpernova09 commented on July 17, 2024

TalkApi::getComments() doesn't check any headers, the request simply returns ["Endpoint not found"] Rather than check for that string in web2 I think we should maybe have the Endpoint not found changed to return false? (which we do check for and throw an exception)

from joindin-web2.

iansltx avatar iansltx commented on July 17, 2024

Issue there is we're using file_get_contents() to grab the response, which means it'll never return boolean false if we get a response at all. So just changing the response body doesn't help us.

Apparently https://www.php.net/manual/en/reserved.variables.httpresponseheader.php would allow us to get the response headers, but...that feels a bit icky given that it's a magically appearing local variable.

from joindin-web2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.