Git Product home page Git Product logo

Comments (3)

acarl005 avatar acarl005 commented on June 15, 2024 6

I added a MySQL/MariaDB dialect.

To use it you must pass joinMonster an options Object with a 'dialect' property set to 'mysql'. See the API docs for details.

I don't know which library you are using to connect to your database. If you are using knex, there is one thing you should watch out for. knex.raw returns different objects based on the knex dialect being used. It may not work with the exact code from the docs. Just double check the shape of that object before returning it from the callback. You may have to change this...

return joinMonster(resolveInfo, {}, sql => {
    return knex.raw(sql)
})

... to something like this...

return joinMonster(resolveInfo, {}, sql => {
    return knex.raw(sql).then(result => result[0])
}, { dialect: 'mysql' })

Please let me know if this works. If so, the issue can be closed.

from join-monster.

acarl005 avatar acarl005 commented on June 15, 2024 1

I see. The problem is the different meaning of double quotes in MySQL/MariaDB.

In SQLite3 and Postgres, which is what Join Monster is tested on, double quotes are used around an identifier to escape certain characters, like whitespace and capital letters. However, MySQL uses double quotes for a string literal. For MySQL, backticks should be used instead.

This means a new dialect will need to be introduced for MySQL/MariaDB. It's a simple fix and I can get around to it in a few days.

from join-monster.

halallahh avatar halallahh commented on June 15, 2024

Works perfectly!

from join-monster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.