Git Product home page Git Product logo

Comments (3)

johnpatrickmorgan avatar johnpatrickmorgan commented on May 18, 2024 1

Thanks, yes that seems like a good short-term approach. As an aside, I think U+2019 is the preferred character for possessive apostrophes, which would avoid the issue in this case at least.

from wtfautolayout.

johnpatrickmorgan avatar johnpatrickmorgan commented on May 18, 2024

Thanks for raising this issue. This relates to the identifier parser in ConstraintsParser+Instances.swift:

static let identifier = many(identifierCharacter.butNot(sqm), boundedBy: sqm).asString()

Currently it does not allow single-quote marks, which stops it from greedily consuming the whole line as an identifier. It will be a challenge to address this issue within the current limitations of the parsing framework, especially to avoid unrelated errors being reported as bad identifiers (since the framework reports the error furthest along the input stream).

I'll mark this as an enhancement, and give it some thought. Thanks again.

from wtfautolayout.

mdiasdev avatar mdiasdev commented on May 18, 2024

Thanks @johnpatrickmorgan, that sounds great! Is it possible to detect that there's an odd number of apostrophes and update the error message to reflect that as a short-term fix? Admittedly I have not looked through the source code -- so I don't know if it's possible -- just trying to offer some potential help for other developers scratching their heads as I was yesterday

from wtfautolayout.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.