Pagination doesn't work for more than 3 pages about pixyll HOT 8 CLOSED

Your pull request was denied?! I never saw one on my end. If you'd like to send another PR I'd be happy to merge in this fix. Otherwise I can add it on my end.

Thank you very much for catching this!

from pixyll.

Went ahead and fixed this in #33. Thanks @cassidoo!

from pixyll.

Looks like I had to slightly tweak the fix, which is in PR #35.

The line if paginator.page == 2 handles a weird case where the paginator attempts to link to /page1 instead of /. So switching the link in the else case to <a class="pagination-item" href="{{ site.baseurl }}/page{{paginator.previous_page}}">Newer</a> was able to solve it.

Thanks again!

from pixyll.

Awesome. Yeah I kept getting a 403 every time I tried submitting one, which is weird.

But anyway, glad it's fixed! Thanks for the cool theme! :)

from pixyll.

Were you attempting to open up a PR from a fork?

Glad you like the theme, and thank you for reporting the issue.

from pixyll.

No, I was doing it off the master from a new branch.

from pixyll.

Ah. Github will only allow a PR to be opened from your own fork if you don't have write access to the main repository, known as the fork & pull model.

from pixyll.

Ohh. I should have known that. Thanks for the tip. :)

from pixyll.