Git Product home page Git Product logo

Comments (7)

aaitbr avatar aaitbr commented on June 21, 2024 1

@johnmaguire Thank u ! i'll see that
& I'll let you know if anything is unclear ! if you don't mind

from cardinal.

MelstromH avatar MelstromH commented on June 21, 2024 1

Hi, is this issue still open? It seems that several other people have made attempts.

from cardinal.

rijandev avatar rijandev commented on June 21, 2024

John Iā€™d like to contribute to this project. I am new to Open source contribute. How do you suggest I go about adding the music signs?

from cardinal.

johnmaguire avatar johnmaguire commented on June 21, 2024

Hi @rijandev -

The first step would be checking the Youtube Data API to find a way to detect if the video belongs to a music category.

The next step would be to check for this data in the plugin itself (probably in _get_video_info), and add some sort of symbol in the event that you detect that category (in _parse_item): https://github.com/JohnMaguire/Cardinal/blob/master/plugins/youtube/plugin.py

Finally, test the functionality manually by connecting the bot to an IRC network and trying .yt <some song name> as well as pasting a URL to a music video, and verifying that it correctly adds the music symbols. You shouldn't need to request an API key, as a Youtube API key is included in this repository (since Youtube doesn't rate limit or anything.)

from cardinal.

aaitbr avatar aaitbr commented on June 21, 2024

Hey @johnmaguire
I'm new to the world of contribution. Can i start by working on this one ? if it's not done yet !

from cardinal.

johnmaguire avatar johnmaguire commented on June 21, 2024

@aaitbr Please go ahead! This API might provide a list of categories, which we can check to see if there's any way to find music-related ones: https://developers.google.com/youtube/v3/docs/videoCategories/list

from cardinal.

johnmaguire avatar johnmaguire commented on June 21, 2024

Thanks, you're correct, this issue was resolved.

from cardinal.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    šŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. šŸ“ŠšŸ“ˆšŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ā¤ļø Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.