Comments (7)
@johnmaguire Thank u ! i'll see that
& I'll let you know if anything is unclear ! if you don't mind
from cardinal.
Hi, is this issue still open? It seems that several other people have made attempts.
from cardinal.
John Iād like to contribute to this project. I am new to Open source contribute. How do you suggest I go about adding the music signs?
from cardinal.
Hi @rijandev -
The first step would be checking the Youtube Data API to find a way to detect if the video belongs to a music category.
The next step would be to check for this data in the plugin itself (probably in _get_video_info
), and add some sort of symbol in the event that you detect that category (in _parse_item
): https://github.com/JohnMaguire/Cardinal/blob/master/plugins/youtube/plugin.py
Finally, test the functionality manually by connecting the bot to an IRC network and trying .yt <some song name>
as well as pasting a URL to a music video, and verifying that it correctly adds the music symbols. You shouldn't need to request an API key, as a Youtube API key is included in this repository (since Youtube doesn't rate limit or anything.)
from cardinal.
Hey @johnmaguire
I'm new to the world of contribution. Can i start by working on this one ? if it's not done yet !
from cardinal.
@aaitbr Please go ahead! This API might provide a list of categories, which we can check to see if there's any way to find music-related ones: https://developers.google.com/youtube/v3/docs/videoCategories/list
from cardinal.
Thanks, you're correct, this issue was resolved.
from cardinal.
Related Issues (20)
- Cardinal choking on non-UTF8 strings since Python 3 upgrade
- URL can't contain control characters.
- Cardinal state isn't persistent across reconnections
- sed plugin does not understand actions
- sed plugin should not respond if a replacement fails
- seen plugin should not send control codes in messages if +c is set on the channel HOT 1
- Errors from the server should be shown in Cardinal logs HOT 1
- seen plugin does not understand actions
- Some wiki lookups result in incorrect formatting
- Replace setup function with entrypoint
- Wikipedia issues with case & blank paragraphs
- Option to restrict urls.detection events to specific desired plugins? HOT 7
- Add config for different command trigger HOT 2
- Switch from retired Yahoo Weather API to OpenWeatherMap (or another free API) HOT 3
- Unload plugins when disconnected from server HOT 1
- New OpenSSL breaks Cardinal
- Add ability to block callbacks in particular channels
- Ignore channels marked +s/+p in the seen plugin
- Race condition with urls.detection event - plugins loaded before urls don't register
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
š Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ššš
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ā¤ļø Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cardinal.