Incorrect warning for final fields about parceler HOT 10 CLOSED

Here's the relevant discussion: #21. Please share a different argument/perspective if you like.

TLDR: You can make your field either transient or @Transient to avoid serialization and the associated warning.

from parceler.

Thanks, that's what I've done - and sorry for not seeing the other issue. Just seemed like strange default behavior.

from parceler.

It's more than ok.. yeah, I agree it's strange behavior. I'm still open to changing it of course.

from parceler.

I'm reopening this because the warning is incorrect and "strange" - I have a public static final variable, yet the warning says I should make it non-private.

from parceler.

So the question is: Do we ignore static fields, final fields or the combination static final? If we do ignore, then should we turn these on by annotating by @ParcelProperty?

from parceler.

I think the current implementation has consistency in its favor.

Here are my thoughts on each case:

static (including static final) should not be parcelled unless annotated and not trigger a warning, I think this is enough of an edge case that if you want to parcel it you should come to the page and read the documentation. I believe this because static variables are more indicative of application state, not object state. And the idea is to parcel the object, not the application state.

final should trigger a warning - but the warning should be consistent with the declared field, specifically, in my case, it should not suggest that I make it non-private when it's already non-private.

from parceler.

Ah, I didn't notice the language. Here's the relevant fix to the warning: johncarl81/transfuse@87b4ebe

from parceler.

Thanks, and after thinking some more, I think just disabling the warnings for static fields would be good enough.

from parceler.

Currently I don't think static fields generate warnings... Only if they are private or final would they trigger a warning.

from parceler.

I'm going to close this issue. Please reopen if you have more.

from parceler.