Git Product home page Git Product logo

Comments (7)

johncarl81 avatar johncarl81 commented on August 10, 2024

Yikes... can you share the stacktrace and possibly the bean you've set up?

from parceler.

aivanyuk avatar aivanyuk commented on August 10, 2024

I have the same issue if there are cross-dependencies between parcel-annotated classes, for example we have

public class Companies {

    List<BranchItem> mBranches;

    List<CompanyItem> mCompanies;

    @Parcel
    public static class BranchItem {
        List<CompanyItem> mCompanies = new ArrayList<>();
        String mSystemId;
    }

    @Parcel
    public static class CompanyItem {
        List<BranchItem> mBranches = new ArrayList<>();
        String mSystemId;
    }
}

Code generation will fail with the following stacktrace:

Exception in thread "pool-36-thread-3" java.lang.StackOverflowError
    at java.util.HashMap.putVal(HashMap.java:628)
    at java.util.HashMap.put(HashMap.java:611)
    at org.parceler.internal.Generators.add(Generators.java:81)
    at org.parceler.internal.Generators.addPair(Generators.java:69)
    at org.parceler.internal.Generators.addPair(Generators.java:57)
    at org.parceler.internal.Generators.addPair(Generators.java:53)
    at org.parceler.internal.ParcelerModule.addGenerators(ParcelerModule.java:176)
    at org.parceler.internal.ParcelerModule.getGenerators(ParcelerModule.java:162)
    at org.parceler.internal.Parceler$$ParcelableGenerator$$Provider$$0.get(Parceler$$ParcelableGenerator$$Provider$$0.java:211)
    at org.parceler.internal.Parceler$$ParcelableGenerator$$Provider$$0.get(Parceler$$ParcelableGenerator$$Provider$$0.java:15)
    at org.parceler.internal.generator.ParcelReadWriteGenerator.generateReader(ParcelReadWriteGenerator.java:54)
    at org.parceler.internal.generator.ListReadWriteGenerator.generateReader(ListReadWriteGenerator.java:84)
    at org.parceler.internal.ParcelableGenerator.buildReadFromParcelExpression(ParcelableGenerator.java:282)
    at org.parceler.internal.ParcelableGenerator.buildReadFromParcel(ParcelableGenerator.java:234)
    at org.parceler.internal.ParcelableGenerator.buildParcelRead(ParcelableGenerator.java:166)
    at org.parceler.internal.generator.ParcelReadWriteGenerator.generateReader(ParcelReadWriteGenerator.java:54)
    at org.parceler.internal.generator.ListReadWriteGenerator.generateReader(ListReadWriteGenerator.java:84)
    at org.parceler.internal.ParcelableGenerator.buildReadFromParcelExpression(ParcelableGenerator.java:282)
    at org.parceler.internal.ParcelableGenerator.buildReadFromParcel(ParcelableGenerator.java:234)
    at org.parceler.internal.ParcelableGenerator.buildParcelRead(ParcelableGenerator.java:166)
    at org.parceler.internal.generator.ParcelReadWriteGenerator.generateReader(ParcelReadWriteGenerator.java:54)
    at org.parceler.internal.generator.ListReadWriteGenerator.generateReader(ListReadWriteGenerator.java:84)
    at org.parceler.internal.ParcelableGenerator.buildReadFromParcelExpression(ParcelableGenerator.java:282)
    at org.parceler.internal.ParcelableGenerator.buildReadFromParcel(ParcelableGenerator.java:234)
    at org.parceler.internal.ParcelableGenerator.buildParcelRead(ParcelableGenerator.java:166)
    at org.parceler.internal.generator.ParcelReadWriteGenerator.generateReader(ParcelReadWriteGenerator.java:54)
    at org.parceler.internal.generator.ListReadWriteGenerator.generateReader(ListReadWriteGenerator.java:84)
    at org.parceler.internal.ParcelableGenerator.buildReadFromParcelExpression(ParcelableGenerator.java:282)
    at org.parceler.internal.ParcelableGenerator.buildReadFromParcel(ParcelableGenerator.java:234)
    at org.parceler.internal.ParcelableGenerator.buildParcelRead(ParcelableGenerator.java:166)
    at org.parceler.internal.generator.ParcelReadWriteGenerator.generateReader(ParcelReadWriteGenerator.java:54)
    at org.parceler.internal.generator.ListReadWriteGenerator.generateReader(ListReadWriteGenerator.java:84)
    at org.parceler.internal.ParcelableGenerator.buildReadFromParcelExpression(ParcelableGenerator.java:282)
    at org.parceler.internal.ParcelableGenerator.buildReadFromParcel(ParcelableGenerator.java:234)
    at org.parceler.internal.ParcelableGenerator.buildParcelRead(ParcelableGenerator.java:166)

from parceler.

johncarl81 avatar johncarl81 commented on August 10, 2024

Ah, yeah, that makes sense. 0.2.11 introduced a performance enhancement to embed serialization of sub-properties within the given annotated class (570fa7b). Maybe the fix should be to revert this, or check if there is a property serialization loop.

from parceler.

johncarl81 avatar johncarl81 commented on August 10, 2024

Ok, I've fixed this and retained the performance benefits. @Jogan, @aivanyuk, If you could please try out 0.2.12-SNAPSHOT and let me know if it works for you and I'll release 0.2.12.

from parceler.

aivanyuk avatar aivanyuk commented on August 10, 2024

I've tried out 0.2.12-SNAPSHOT and everything seems to work, thanks!

from parceler.

johncarl81 avatar johncarl81 commented on August 10, 2024

Great. Releasing to central now.

from parceler.

Jogan avatar Jogan commented on August 10, 2024

@johncarl81 thanks!

from parceler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.