Git Product home page Git Product logo

Comments (7)

johncarl81 avatar johncarl81 commented on August 10, 2024

@patrickhammond Yes, this is related. Does compilation and code generation complete successfully despite the stacktrace? Also, this should be fixed in upcoming 0.2.6 release and you can test it out in the current 0.2.6-SNAPSHOT.

from parceler.

patrickhammond avatar patrickhammond commented on August 10, 2024

It looks like compilation and code generation were occurring. Not seeing this error in 0.2.6-SNAPSHOT.

Unrelated, are there any proguard flags that are required that you're aware are needed? Running into runtime crashes in a proguarded app where Parcels line 149 (findClass) is returning a null value and causing line 135 (ParcelCodeRepository.get) to throw a ParcelerRuntimeException.

Can put together a sample project later if needed.

from parceler.

johncarl81 avatar johncarl81 commented on August 10, 2024

Fantastic.

Proguard is probably removing the org.parceler.Parceler$$Parcels class which is required for the Parcels utility class to run. Most everything else should be statically linked through that class. So this may do the trick:

-keep org.parceler.Parceler$$Parcels

@patrickhammond Could you confirm so that this could be added to the readme.

I'll also look at issuing a solid release of Parceler in the coming week.

from parceler.

patrickhammond avatar patrickhammond commented on August 10, 2024

This looks like the winning combination:

-keep interface org.parceler.Parcel
-keep @org.parceler.Parcel class * { *; }
-keep class **$$Parcelable { *; }
-keep class org.parceler.Parceler$$Parcels

Just sent in #15 with a minimal app using this configuration.

from parceler.

patrickhammond avatar patrickhammond commented on August 10, 2024

Might also consider replacing the top line with -keep interface org.parceler.** to capture all of the annotations.

from parceler.

johncarl81 avatar johncarl81 commented on August 10, 2024

@patrickhammond I believe this is fixed via johncarl81/transfuse#69. Please let me know if you see this anymore.

from parceler.

johncarl81 avatar johncarl81 commented on August 10, 2024

Closing as I have not seen this personally or been notified of it happening. Feel free to reopen if this is witnessed again.

from parceler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.