Git Product home page Git Product logo

Comments (7)

JohannesKlauss avatar JohannesKlauss commented on August 18, 2024

@MishaFrenkman thank you very much for your bug report. This issue got fixed with #99. I published a new version (1.4.0). If you update the package the issue will be gone.

from react-hotkeys-hook.

amanharwara avatar amanharwara commented on August 18, 2024

Does this not work with the context API? The state is stale when using the Context API.
Here is example code where it doesn't work:

const Component = () => {
	const {state, setState} = useContext(context);
	
	useEffect(()=>{
		setState({
			example: 1
		});
	});

	useHotkeys('ctrl+a', ()=>{
		console.log(state);
	});

	return (<div></div>);
}

Is there something I'm doing wrong or does it not support the Context API?

from react-hotkeys-hook.

JohannesKlauss avatar JohannesKlauss commented on August 18, 2024

I really don't know how your context is working, where it is wrapped. Also your useEffect does not specify a dep array.

from react-hotkeys-hook.

amanharwara avatar amanharwara commented on August 18, 2024

Turns out adding the context value to the useHotkeys dep array fixed it. Thanks.

from react-hotkeys-hook.

KalpeshPopat avatar KalpeshPopat commented on August 18, 2024

This bug has resurfaced, i am using v2.1.3 and events fired via shortcut keys are unable to read the state.

from react-hotkeys-hook.

JohannesKlauss avatar JohannesKlauss commented on August 18, 2024

Are you using the deps array of the useHotkeys array? Otherwise you will always get stale state. The handler is memoised and has to update itself depending on the values you give it.

from react-hotkeys-hook.

KalpeshPopat avatar KalpeshPopat commented on August 18, 2024

Thanks for the response, i will respond on other thread.

from react-hotkeys-hook.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.