Git Product home page Git Product logo

Comments (10)

vpetrusevici avatar vpetrusevici commented on August 22, 2024 2

Big thanks to @vpetrusevici for making a pull request so promptly and to @johannesjo for approving it. I can confirm it works npw for Material v13.0.0. I had to use import @import '~angular-material-css-vars/src/lib/main'; not sure what was a reference to public-util about

It was about all scss files. They just changed location after builder update.

from angular-material-css-vars.

vpetrusevici avatar vpetrusevici commented on August 22, 2024 1

The same error. Looks like material changed scss again)

from angular-material-css-vars.

vpetrusevici avatar vpetrusevici commented on August 22, 2024 1

@johannesjo Important change that i missed is scss imports.
I changed builder to @angular-devkit/build-angular:ng-packagr, so now scss can be imported like this
@import "~angular-material-css-vars/src/lib/public-util";
instead of
@import "~angular-material-css-vars/public-util";
Sorry. I noticed this only after updating the dependencies of my project.

from angular-material-css-vars.

johannesjo avatar johannesjo commented on August 22, 2024 1

It was about all scss files. They just changed location after builder update.

If this is the only complication, I think we're all fine! Or is there anything I can do to improve this @vpetrusevici ?

Anyway, thank you very much again @vpetrusevici !! Great job!

from angular-material-css-vars.

vpetrusevici avatar vpetrusevici commented on August 22, 2024

angular/components#23889

from angular-material-css-vars.

johannesjo avatar johannesjo commented on August 22, 2024

Angular 13 is not yet supported. PRs dealing with this are welcome!

from angular-material-css-vars.

vpetrusevici avatar vpetrusevici commented on August 22, 2024

@johannesjo You're welcome! :) Demo works, lib build is successful.

from angular-material-css-vars.

johannesjo avatar johannesjo commented on August 22, 2024

@vpetrusevici I don't quite understand as I can't find any any occurrences of that import. Could you maybe explain?

from angular-material-css-vars.

vpetrusevici avatar vpetrusevici commented on August 22, 2024

image
These files were in the main folder before, but now they are here.

Because of this change
image

from angular-material-css-vars.

mruknowme avatar mruknowme commented on August 22, 2024

Big thanks to @vpetrusevici for making a pull request so promptly and to @johannesjo for approving it. I can confirm it works npw for Material v13.0.0.
I had to use import @import '~angular-material-css-vars/src/lib/main'; not sure what was a reference to public-util about

from angular-material-css-vars.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.