Comments (3)
shabbyrobe
commented on August 19, 2024
2
Great find @jwoffindin! Thank you! It looks like I didn't read the spec properly. From https://tools.ietf.org/html/rfc7233#section-2.1:
A client can limit the number of bytes requested without knowing the
size of the selected representation. If the last-byte-pos value is
absent, or if the value is greater than or equal to the current
length of the representation data, the byte range is interpreted as
the remainder of the representation (i.e., the server replaces the
value of last-byte-pos with a value that is one less than the current
length of the selected representation).
If you'd like to submit a PR, that'd be great! There's a half-decent test case in range_test.go for this that'll also need an update.
from gofakes3.
johannesboyne
commented on August 19, 2024
A PR would be awesome! And as @shabbyrobe wrote, great finding.
from gofakes3.
shabbyrobe
commented on August 19, 2024
Pretty sure #37 got this all sewn up, so I'll close. Thanks @jwoffindin!
from gofakes3.
Related Issues (20)
- how much features missing from s3 api HOT 4
- Amazon have deprecated Path-style URL access to S3 buckets HOT 2
- Persist multipart uploads in backend HOT 7
- S3 Select mocking support HOT 4
- ListObjects: IsTruncated omit when its value is false HOT 2
- PutObject doesn't allow zero length files
- panic using unaligned 64-bit atomics on 32-bit architectures HOT 1
- Feature request: support AWS Signature Version 4 Chunk Upload
- Multipart uploads fail with minio client due to mismatched etags HOT 1
- Switch to active boltdb fork HOT 1
- sftpgo s3afero compatibility HOT 7
- Content-Disposition metadata is ignored when creating object HOT 1
- aws-sdk-go-v2 example HOT 2
- PutObjectTagging overwrites metadata HOT 1
- ListBucket in s3bolt backend does not honor page.Marker value HOT 1
- Putting a tag overrides the body
- CommonPrefixes logic does not work on non-terminated prefix (without ending '/')
- ListObject startAfter not working when key does not exist (s3mem) HOT 1
- Race condition listing objects while deleting HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gofakes3.