Git Product home page Git Product logo

Comments (3)

joelee2012 avatar joelee2012 commented on July 18, 2024

@g3n35i5 this is similar with psf/requests#3912, you need close Client explicitly in some case. but it will not case your test failed.

from api4jenkins.

g3n35i5 avatar g3n35i5 commented on July 18, 2024

@joelee2012 you're right, my tests are failing because I run them in warnings as errors mode.
This is indeed similar to the linked issue but I still think that wrapping the socket in a context manager here would be a good idea.

from api4jenkins.

joelee2012 avatar joelee2012 commented on July 18, 2024

@g3n35i5 yes it can be a context manager and welcome to create PR 😄

from api4jenkins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.