adeb prepare advertises --distro flag but doesn't accept it about adeb HOT 7 OPEN

Looks like the DISTRO is hardcoded in androdeb.

I think this patch should fix it?

> git diff
diff --git a/androdeb b/androdeb
index a2ee65b..60c5566 100755
--- a/androdeb
+++ b/androdeb
@@ -63,6 +63,7 @@ case $key in
     --sshpass) SSHPASS="sshpass -p$2"; shift || true; shift || true; ;;
     --build-image) BI=1; BUILD_IMAGEF=$2; SKIP_DEVICE=1; DOWNLOAD=0; shift || true; shift || true; ;;
     --debug) set -x; shift || true; ;;
+    --distro) DISTRO="$2"; shift || true; shift || true; ;;
     *) c_error "Unknown option ($1)"; usage; ;;
 esac
 done

from adeb.

I no longer maintain it but I'm happy to accept PRs. Could you send me a PR for this?

from adeb.

from adeb.

Before I send a bunch of PRs, I might ask: do you know of an easier way than this project to run bpftrace on Android? (I'm wondering/hoping if the lack of maintenance may be connected to a better way emerging that obsoletes this? e.g. can we copy a statically linked bpftrace to Android now?)

from adeb.

Just linking up some issues: bpftrace/bpftrace#342 (comment) discusses some constraints around statically linking bpftrace -- the problem seems to be that bpftrace compiles programs with LLVM and LLVM is huge.

from adeb.

I no longer maintain it but I'm happy to accept PRs. Could you send me a PR for this?

#48 Can you review this PR?

from adeb.

Before I send a bunch of PRs, I might ask: do you know of an easier way than this project to run bpftrace on Android? (I'm wondering/hoping if the lack of maintenance may be connected to a better way emerging that obsoletes this? e.g. can we copy a statically linked bpftrace to Android now?)

This project can run bpftrace directly on Android: https://github.com/facebookexperimental/ExtendedAndroidTools

from adeb.