Git Product home page Git Product logo

Comments (3)

JoaquimLey avatar JoaquimLey commented on August 23, 2024

Hello @pzienowicz
Well, this goes a bit against the guidelines. I know the component isn't exactly following but:

Create a custom FabOptions (extend) and have a public method calling the open/close private methods.

I wanted to keep it away from the public API since it might need changes (new params etc).

What do you think?

from faboptions.

pzienowicz avatar pzienowicz commented on August 23, 2024

Hi @JoaquimLey.

Yes, I was thinking about this way to resolve it and of course it is correct and easy to achieve.
But I think many devs want to manage the state of fabOptions in their code so you could make it easier :)

You could also think about "onBlur" feature - when clicked outside the menu, it should be closed automatically. This is exactly what I need to do, so if this will be implemented, public open/close methods are no longer needed.

What do you think?
Thanks for the great library!

from faboptions.

JoaquimLey avatar JoaquimLey commented on August 23, 2024

@pzienowicz Sorry for the late response! I missed the notification ☮️ .
Thank you for the kind words 🙏 .

Well, I do get where you coming from and I can see how useful it would be but, that's actually a bit outside of the scope of the view, I would need to handle touch events that are outside of the view, as you can imagine that may cause some strange issues.
Sorry but I'm a bit hesitant on opening methods, I estimate around 300 different projects using the library and once it's public it's there forever to maintain.

I'm going to leave this issue open for now and see if it gets +1's.

from faboptions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.