Comments (3)
Hello @pzienowicz
Well, this goes a bit against the guidelines. I know the component isn't exactly following but:
Create a custom FabOptions
(extend) and have a public
method calling the open
/close
private methods.
I wanted to keep it away from the public API since it might need changes (new params etc).
What do you think?
from faboptions.
Hi @JoaquimLey.
Yes, I was thinking about this way to resolve it and of course it is correct and easy to achieve.
But I think many devs want to manage the state of fabOptions in their code so you could make it easier :)
You could also think about "onBlur
" feature - when clicked outside the menu, it should be closed automatically. This is exactly what I need to do, so if this will be implemented, public open
/close
methods are no longer needed.
What do you think?
Thanks for the great library!
from faboptions.
@pzienowicz Sorry for the late response! I missed the notification ☮️ .
Thank you for the kind words 🙏 .
Well, I do get where you coming from and I can see how useful it would be but, that's actually a bit outside of the scope of the view, I would need to handle touch events that are outside of the view, as you can imagine that may cause some strange issues.
Sorry but I'm a bit hesitant on opening methods, I estimate around 300 different projects using the library and once it's public
it's there forever to maintain.
I'm going to leave this issue open for now and see if it gets +1's.
from faboptions.
Related Issues (20)
- Incorrect display after replacing fragment HOT 7
- Adding menu programmatically HOT 3
- Button icons are shown after expanding and collapsing FabOptions quickly HOT 1
- Customize icons HOT 2
- can it be show on home screen as a floating shortcut? HOT 1
- No static method getScreenWidthDp Error HOT 6
- Menu not close on backPressed() HOT 2
- A problem occurred evaluating script. HOT 9
- compatibility issue HOT 3
- Must always have four options HOT 9
- What causes Unknown constant tag 114 in class file? HOT 2
- [Request] - OnLongClickListener HOT 3
- Exception android.widget.ImageView cannot be cast to android.support.v7.widget.AppCompatImageView HOT 7
- Menu icons or menu can't be changed programmatically HOT 8
- requestLayout() improperly called by com.joaquimley.faboptions.FabOptionsButtonContainer HOT 4
- Hi, how to custom the overflow button ? HOT 1
- change the Image of the Fab. HOT 1
- keep menu open ! HOT 1
- Increase button menu icon size HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from faboptions.