Make icon size and color independent of the text about android-iconify HOT 7 CLOSED

Thanks for your contribution, I'll take a look at it as soon as I can.
It's already possible to do this, using HTML like in the sample, but it would indeed be nice to use it with this kind of syntax.

from android-iconify.

Too bad we don't have the same formatting rules, your changes are difficult to identify clearly. My bad, I should have published them. :)

from android-iconify.

I wasn't able to make it a different size since the font-size tag is not recognized by Android. I saw that the changes were poorly formatted indeed don't know what happend.

Hope you can merge the changes into your repo =)

from android-iconify.

I noticed you changed the minSdkVersion of the sample app, why is that ?

I can't merge your PR as it is, since it's not atomic: you should only make changes to the lines concerned by your feature. I think our IDE's formatting rules are different and that causes a diff on almost every single line of code. Tell me what IDE you're using and I'll export my formatting settings. (I'm using intelliJ default settings)

from android-iconify.

The ValueAnimator is supported from SDK 11 thats why i updated the minSdkVersion.
I'm also using intelliJ so if you send me your formatting settings ill try to reformat the code to be more acceptable =)

from android-iconify.

Oh, thanks, I thought I used NineOldAndroids! Now it's compatible with 8.

I committed my settings at the project's root, idea-editor-settings.jar. I'm not sure I checked the correct options in IDEA so tell me if something's missing.

I'll be pleased to review and commit your changes after that. 👍

from android-iconify.

Any update ?

from android-iconify.