Git Product home page Git Product logo

Comments (12)

swang96 avatar swang96 commented on September 26, 2024

More specifically, there is now a ""GITHUB" navbar tab that links to piazza.

from cs480_s18.

ckilcrease avatar ckilcrease commented on September 26, 2024

I also see this issue in Chrome 63.0.3239.132
The issue seems to be in _includes/header.html in the following line:
<li><a href="{{site.piazza_site}}" target="_blank">GitHub</a></li>

from cs480_s18.

S1MB10T3 avatar S1MB10T3 commented on September 26, 2024

I mention this error on issue #2 lol

from cs480_s18.

ashleytqy avatar ashleytqy commented on September 26, 2024

Can I work on this?

from cs480_s18.

joannakl avatar joannakl commented on September 26, 2024

duplicate of #2

from cs480_s18.

ashleytqy avatar ashleytqy commented on September 26, 2024

@joannakl

The fix for Issue #2 in PR #62 replaces the 'GitHub' tab with the 'Piazza' tab. Would it be okay if I add the GitHub tab back and link it to either – https://github.com/joannakl/cs480_s18/ or https://github.com/nyu-ossd-s18?

from cs480_s18.

joannakl avatar joannakl commented on September 26, 2024

@ashleytqy you should comment on PR #62 and state that it's an incomplete fix. Or, if it turns out that the original poster of this issue @GS-14 is happy with the fix, then another bug report can be opened (or one of the closed issues can be reopen to addess this missing GitHub link)

from cs480_s18.

GS-14 avatar GS-14 commented on September 26, 2024

Just to clarify, I intended for this issue to be separate from #2 in the sense that someone would have to fix the existing tab (which #62 seems to resolve), but there's still one tab missing in the header. I can't reopen my own issue, but #62 isn't a fix for it.

from cs480_s18.

ashleytqy avatar ashleytqy commented on September 26, 2024

@joannakl is it possible for you to re-open this issue, as per @GS-14 's comment? thanks!

from cs480_s18.

mzguimaraes avatar mzguimaraes commented on September 26, 2024

If this is still open, maybe the duplicate tag should be removed. People probably aren't even looking at this issue because of it.

from cs480_s18.

joannakl avatar joannakl commented on September 26, 2024

@mzguimaraes done

from cs480_s18.

GS-14 avatar GS-14 commented on September 26, 2024

@joannakl I think the duplicate label is still there.

from cs480_s18.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.