Git Product home page Git Product logo

Comments (3)

joan2937 avatar joan2937 commented on August 26, 2024

This is more to do with philosophy than anything else.

The user should not be calling a function with incorrect parameters. If a function is called incorrectly it indicates there is a logic error in the program. I do not believe that such logic errors should be ignored, they should be corrected.

from pigpio.

Loris1123 avatar Loris1123 commented on August 26, 2024

Sure, I totally agree with this.
For functions like I posted, it is a bit annoying to check if i < 0: i=0.
A way to solve this would be a kwarg like this:

def set_PWM_dutycycle(self, user_gpio, dutycycle, error_save=False):
if error_save:
    if dutycycle < 0:
        dutycycle = 0
    if dutycycle > 255:
        dutycycle = 255
return _u2i(_pigpio_command(
     self.sl, _PI_CMD_PWM, user_gpio, int(dutycycle)))

from pigpio.

joan2937 avatar joan2937 commented on August 26, 2024

An even better way would be to correct the logic error.

I shall not be changing the way error handling works in this or similar functions.

By the way the dutycycle range defaults to 0..255, but the user can change the range.

from pigpio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.