Git Product home page Git Product logo

Comments (1)

jlhutch avatar jlhutch commented on August 23, 2024

Design.

The cache.clear() method can simply blow the cache away (current behavior) or it can evict each entry calling the callback function, if there is one. It is not obvious, at least to me, that either behavior is clearly more intuitive.

At a practical level, the WriteBackCacheManager class gives an example of the tradeoffs that motivated the API's design.

The clear() method there needs to clear the cache and the backing storage. Since the storage is being cleared anyway, we don't want the callbacks executing, we really want to blow the cache away.

In the sync() method we need to write back the dirty cache entries. If cache.clear() did called the callbacks, it would make this simpler. However, the performance would not be as good, because every entry in the cache would have its callback executed so that it could be looked up in the dirty set. For many cases, it is faster to just walk the dirty set directly, sync those, then blow the cache away.

from pylru.

Related Issues (18)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.