Git Product home page Git Product logo

Comments (7)

diosney avatar diosney commented on June 6, 2024

+1 Same here.

from rrule.

NaWer avatar NaWer commented on June 6, 2024

+1
ByDay can achieve the same result :

RRule.fromString('FREQ=MONTHLY;BYDAY=+2MO,-1MO').toText();
// every month on the 2nd Monday and last Monday

from rrule.

jkbrzt avatar jkbrzt commented on June 6, 2024

The support is incomplete (as mentioned here), but there should be a warning in the string returned by toText() that the textual representation is approximate.

It looks like isFullyConvertibleToText() is broken and always returns true.

var r = RRule.fromString('FREQ=MONTHLY;BYDAY=MO;BYSETPOS=2,-1')
r.isFullyConvertibleToText()
true  // Should be false

from rrule.

rameshsrinivasan avatar rameshsrinivasan commented on June 6, 2024

+1 Same here.

from rrule.

rameshsrinivasan avatar rameshsrinivasan commented on June 6, 2024

I have fixed this issue.
Please find below lines.

         if(typeof options.bysetpos != 'undefined' && options.bysetpos != '') {
            n = Number(options.bysetpos)
            wday = day;
            wday = RRule[wday].weekday
            options.byweekday.push(new Weekday(wday, n))
          } else {
            wday = RRule[day] // wday instanceof Weekday
            options.byweekday.push(wday)
          }

Line Number 1331 (rrule.js file)
https://github.com/rameshsrinivasan/rrule/blob/master/lib/rrule.js#L1331

from rrule.

rameshsrinivasan avatar rameshsrinivasan commented on June 6, 2024

I have added for only BYSETPOS, U can use it and fix it accordingly.

from rrule.

jungalwala avatar jungalwala commented on June 6, 2024

+1
I have the same issue.

from rrule.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.