Git Product home page Git Product logo

Comments (4)

GoogleCodeExporter avatar GoogleCodeExporter commented on June 1, 2024
Pardon me; that patch apparently didn't work. I'm not sure what I mixed up in 
there, but I'll see if I can get it fixed and reupload when I get a moment.

Original comment by [email protected] on 15 Sep 2010 at 8:33

  • Added labels: ****
  • Removed labels: ****

from fanficfare.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 1, 2024
I forgot to test the filename against the string 'mimetype' rather than the 
(filename, data) tuple. Oops. When this patch worked previously, it was by 
sheer coincidence.

Again, note that there's a performance hit (the ebooks are larger) because all 
files are stored uncompressed; there's a tradeoff between standard compliance 
and compression using this version of Python's ZIP support, unless someone 
knows a way around that.

Original comment by [email protected] on 16 Sep 2010 at 2:54

  • Added labels: ****
  • Removed labels: ****

Attachments:

from fanficfare.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 1, 2024
Adam, I apologize that I didn't realize you'd put patches here for a lot of 
issues until after I'd already coded my own fixes.

In this particular case, my solution is a bit different and allows the chapter 
files to be compressed while mimetype isn't.

Original comment by [email protected] on 16 Oct 2010 at 1:58

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

from fanficfare.

GoogleCodeExporter avatar GoogleCodeExporter commented on June 1, 2024
That's a better fix than I had, in any case; I read that Python's zip module 
didn't support per-file compression options until Python 2.7, but it never 
occurred to me to close and reopen the zipfile using different compression 
options each time.

Original comment by [email protected] on 16 Oct 2010 at 3:57

  • Added labels: ****
  • Removed labels: ****

from fanficfare.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.