Comments (4)
Pardon me; that patch apparently didn't work. I'm not sure what I mixed up in
there, but I'll see if I can get it fixed and reupload when I get a moment.
Original comment by [email protected]
on 15 Sep 2010 at 8:33
- Added labels: ****
- Removed labels: ****
from fanficfare.
I forgot to test the filename against the string 'mimetype' rather than the
(filename, data) tuple. Oops. When this patch worked previously, it was by
sheer coincidence.
Again, note that there's a performance hit (the ebooks are larger) because all
files are stored uncompressed; there's a tradeoff between standard compliance
and compression using this version of Python's ZIP support, unless someone
knows a way around that.
Original comment by [email protected]
on 16 Sep 2010 at 2:54
- Added labels: ****
- Removed labels: ****
Attachments:
from fanficfare.
Adam, I apologize that I didn't realize you'd put patches here for a lot of
issues until after I'd already coded my own fixes.
In this particular case, my solution is a bit different and allows the chapter
files to be compressed while mimetype isn't.
Original comment by [email protected]
on 16 Oct 2010 at 1:58
- Changed state: Fixed
- Added labels: ****
- Removed labels: ****
from fanficfare.
That's a better fix than I had, in any case; I read that Python's zip module
didn't support per-file compression options until Python 2.7, but it never
occurred to me to close and reopen the zipfile using different compression
options each time.
Original comment by [email protected]
on 16 Oct 2010 at 3:57
- Added labels: ****
- Removed labels: ****
from fanficfare.
Related Issues (20)
- adding user and password for ao3 to personal .ini HOT 3
- the update hook tears writes HOT 3
- Python 2 CLI does not output custom metadata or a title page HOT 1
- DeviantArt Adapter: Failure to Download Story HOT 1
- Wrong number of threadmarks being reported for Sufficient Velocity HOT 1
- Is it possible to make FFF ignore the 403 errors. HOT 2
- Get ALL story urls from existing books upgrade HOT 1
- Fanfiction.net stories give a HTTP error each time HOT 1
- [BUG] Error Updating Metadata HOT 1
- fanficfare linux vs windows speed difference HOT 1
- Errors fetching information on the plugin now generate modal error boxes instead of just reporting on the job log like before HOT 1
- Error when downloading from deviant art with login credentials HOT 21
- Spacebattles Threadmarks Pagination Update HOT 1
- [Question] For the Browser Cache method: only check first and last chapter HOT 1
- browser cache path for fanfiction.net doesn't work HOT 9
- Update AO3 anthology not working when a series URL is used HOT 7
- Any way to improve tables on Kindle? HOT 3
- Literotica changes after site UI revamp HOT 35
- Existing story produces 'Story does not exist' error HOT 1
- [literotica.com] Download all Story from User HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from fanficfare.