Git Product home page Git Product logo

Comments (6)

jihchi avatar jihchi commented on May 28, 2024

Would you please try latest commit?

Latest commit (Vite 4 is supported) works on my machine:

$ npm test

> [email protected] test
> vitest

[@jihchi/vite-plugin-rescript] Dependency on @rescript/react
[@jihchi/vite-plugin-rescript] Dependency on @ryyppy/rescript-promise
[@jihchi/vite-plugin-rescript] Dependency on rescript-webapi
[@jihchi/vite-plugin-rescript] Dependency on rescript-vitest
[@jihchi/vite-plugin-rescript] Dependency Finished
[@jihchi/vite-plugin-rescript] >>>> Start compiling
[@jihchi/vite-plugin-rescript] >>>> Finish compiling

 DEV  v0.25.6 /home/jihchi/code/vitejs-template-react-rescript

 ✓ tests/App_test.bs.js (1)

 Test Files  1 passed (1)
      Tests  1 passed (1)
   Start at  05:48:12
   Duration  1.97s (transform 626ms, setup 146ms, collect 178ms, tests 51ms)


 PASS  Waiting for file changes...
       press h to show help, press q to quit

$ npm version
{
  'vite-react-rescript-starter': '1.0.0',
  npm: '8.19.2',
  node: '18.12.1',
  v8: '10.2.154.15-node.12',
  uv: '1.43.0',
  zlib: '1.2.11',
  brotli: '1.0.9',
  ares: '1.18.1',
  modules: '108',
  nghttp2: '1.47.0',
  napi: '8',
  llhttp: '6.0.10',
  openssl: '3.0.7+quic',
  cldr: '41.0',
  icu: '71.1',
  tz: '2022b',
  unicode: '14.0',
  ngtcp2: '0.8.1',
  nghttp3: '0.7.0'
}

from vitejs-template-react-rescript.

krokofant avatar krokofant commented on May 28, 2024

Just did this and testing fails:

npx degit jihchi/vitejs-template-react-rescript my-vitejs-react-rescript
cd my-vitejs-react-rescript
npx vite
npx vitest

image

Tried it with git clone (commit 01f1ca6)

git clone https://github.com/jihchi/vitejs-template-react-rescript.git
cd .\vitejs-template-react-rescript\
npm ci
npm run test

image

❯ npm version
{
  'vite-react-rescript-starter': '1.0.0',
  npm: '9.5.1',
  node: '18.16.0',
  acorn: '8.8.2',
  ada: '1.0.4',
  ares: '1.19.0',
  brotli: '1.0.9',
  cldr: '42.0',
  icu: '72.1',
  llhttp: '6.0.10',
  modules: '108',
  napi: '8',
  nghttp2: '1.52.0',
  nghttp3: '0.7.0',
  ngtcp2: '0.8.1',
  openssl: '3.0.8+quic',
  simdutf: '3.2.2',
  tz: '2022g',
  undici: '5.21.0',
  unicode: '15.0',
  uv: '1.44.2',
  uvwasi: '0.0.15',
  v8: '10.2.154.26-node.26',
  zlib: '1.2.13'
}

Tried on Windows 11.

from vitejs-template-react-rescript.

krokofant avatar krokofant commented on May 28, 2024

Also tried it on macOS and the same nodejs version. Is this not reproducible by you @jihchi ? Are you installing the dependencies with npm ci?

I also tested on the exact same node version you're running and it still fails:

docker run -it --rm --name my-running-script -v "${PWD}:/usr/src/app" -w /usr/src/app node:18.12.1-buster bash
npm ci
npm run test

from vitejs-template-react-rescript.

jihchi avatar jihchi commented on May 28, 2024

Hi @krokofant , I've upgraded the rescript-vitest library and fixed broken test (for more details, click here), it works for me.

Could you try to pull the latest commit (709c172) and verify it?

from vitejs-template-react-rescript.

krokofant avatar krokofant commented on May 28, 2024

@jihchi Yes, it works! 🥳

from vitejs-template-react-rescript.

krokofant avatar krokofant commented on May 28, 2024

@jihchi Could you close this issue? 😊

from vitejs-template-react-rescript.

Related Issues (11)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.