'encode_docsis' generates truncated config about docsis-configfile HOT 7 CLOSED

I have not looked into this yet, but can you show me in the specification where you can specify more than 21 entries? Could there be a limitation in the spec?

from docsis-configfile.

267 $type = pack 'C', $syminfo->{code}; 268 $length = $syminfo->{lsize} == 2 ? pack('n', length $value) : pack('C', length $value); 269 $mic->{$name} = "$type$length$value"; 270 $bytes .= $mic->{$name}; 271 }

The dschannellists $value's length is > 255, so the pack of a single C causes it to wrap - hence the error.

I am not sure if its legal to have the length of value of the channels longer than 255? it may be implicitly illegal if the $length position is limited to 8 bits? i poked around in the spec's but honestly, got lost trying to get a clear answer.

from docsis-configfile.

It would be interesting to see how another encoder solves this. If you can create a config file with the desired result and then attach the binary file, I can try to parse that file and fix this module.

Reason for me being rather passive on this, is because I have not been into DOCSIS tech for over ten years.

from docsis-configfile.

No problem I was pleasantly surprised how quick you responded.

I found that DOCSIS Configuration File creator (which is now here https://github.com/rlaager/docsis) does compile the config however with a "warning: aggregate size of settings block larger than 255, skipping". Decoding it back confirms that it did not include the DsChannelList. So it is more likely that this is not a bug. For now I am treating it as a non issue and exploring alternatives like spiting up the list into two.

Apologies for wasting your time.

from docsis-configfile.

it may be better to check that length <256 and throw a meaningful error?

from docsis-configfile.

I'm re-opening this because I think that DOCSIS::ConfigFile should croak/die on invalid input.

from docsis-configfile.

Sorry for the long wait. This is now fixed.

from docsis-configfile.