Git Product home page Git Product logo

Comments (7)

deepu105 avatar deepu105 commented on June 16, 2024 1

from jhipster-online.

PierreBesson avatar PierreBesson commented on June 16, 2024

Thanks for the report @yfain. I found the bug ! 😃

I regenerated your nyc1 app with jhipster --force and there was no difference at all. So no issue on this side, JHipster Online is correctly generating the app from the yo-rc which was provided.

However when I started the app, indeed you cannot change the language, so I suspected that there is an issue with the .yo-rc.json file generated by JHipster Online.
yo-rc generated by JHipster online

{
  "generator-jhipster": {
    "applicationType": "monolith",
    "gitHubOrganization": "",
    "baseName": "nyc1",
    "packageName": "io.github.jhipster.application",
    "serverPort": 8080,
    "serviceDiscoveryType": false,
    "authenticationType": "jwt",
    "uaaBaseName": "../uaa",
    "hibernateCache": "ehcache",
    "clusteredHttpSession": false,
    "websocket": false,
    "databaseType": "sql",
    "devDatabaseType": "h2Disk",
    "prodDatabaseType": "mysql",
    "searchEngine": false,
    "messageBroker": false,
    "buildTool": "maven",
    "enableSocialSignIn": false,
    "useSass": false,
    "clientPackageManager": "yarn",
    "testFrameworks": [],
    "enableTranslation": false,
    "nativeLanguage": "en",
    "languages": [
      "en",
      "ru"
    ],
    "clientFramework": "angularX",
    "jhipsterVersion": "4.7.0",
    "packageFolder": "io/github/jhipster/application",
    "jwtSecretKey": "3e65d5917f943b623206179b204def4a5b06452a",
    "jhiPrefix": "jhi"
  }
}

yo-rc generated by the CLI

{
  "generator-jhipster": {
     "promptValues": { //<--  LOOK HERE
      "packageName": "com.mycompany.myapp",
      "nativeLanguage": "en"
    },
    "jhipsterVersion": "4.7.0",
    "baseName": "nyc1",
    "packageName": "com.mycompany.myapp",
    "packageFolder": "com/mycompany/myapp",
    "serverPort": "8080",
    "authenticationType": "jwt",
    "hibernateCache": "ehcache",
    "clusteredHttpSession": false,
    "websocket": false,
    "databaseType": "sql",
    "devDatabaseType": "h2Disk",
    "prodDatabaseType": "mysql",
    "searchEngine": false,
    "messageBroker": false,
    "serviceDiscoveryType": false,
    "buildTool": "maven",
    "enableSocialSignIn": false,
    "enableSwaggerCodegen": false,
    "jwtSecretKey": "9233dd865c5a9f0d9808f36747897ff71adb5c2b",
    "clientFramework": "angularX",
    "useSass": false,
    "clientPackageManager": "yarn",
    "applicationType": "monolith",
    "testFrameworks": [],
    "jhiPrefix": "jhi",
    "enableTranslation": true,
    "nativeLanguage": "en",
    "languages": [
      "en",
      "ru"
    ]
  }
}

Notice the promptValues.nativeLanguage that is missing. @jdubois can you give me access to jhipster-online code so I can fix the bug ?

from jhipster-online.

ruddell avatar ruddell commented on June 16, 2024

@PierreBesson Shouldn't we fix the generator to use the nativeLanguage we already store ourselves instead of prompts.nativeLanguage?

from jhipster-online.

PierreBesson avatar PierreBesson commented on June 16, 2024

@Rudell, I don't know much about how the .yo-rc is generated by the cli so if you think this can be fixed in the generator then please go ahead.

from jhipster-online.

jdubois avatar jdubois commented on June 16, 2024

from jhipster-online.

jdubois avatar jdubois commented on June 16, 2024

Not sure about this: @PierreBesson in fact you have no translation in the first file because you have "enableTranslation": false int it... So that's normal.
I'm doing more tests.

from jhipster-online.

jdubois avatar jdubois commented on June 16, 2024

In fact this value is also set to false in the test .yo-rc.json, so that's "normal". But we should improve the UI, and not show any language if "no" is selected.

from jhipster-online.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.