Comments (4)
I wonder if there is a way to have it track that or run some sort of "onDelete" action? The "leases" (role tokens) were cleaned up, at least.
from vault-plugin-secrets-artifactory.
I think that already happen..
I have enabled the secret engine on my acceptance vault and now I want to disable:
/ $ vault secrets disable artifactory
Error disabling secrets engine at artifactory/: Error making API request.
URL: DELETE http://127.0.0.1:8200/v1/sys/mounts/artifactory
Code: 400. Errors:
* failed to revoke "artifactory/token/REDACT/...REDACT" (1 / 3): failed to revoke entry: resp: (*logical.Response)(nil) err: could not get the sytem version: HTTP response 401
the token on the mount is already revoked, so 401 is desirable.
if the token was valid, it would revoke it as far as I understand from the above.
from vault-plugin-secrets-artifactory.
I just start working on this. I'll check it out @EvertonSA and see if that's the case already.
from vault-plugin-secrets-artifactory.
@EvertonSA I was not able to replicate your result. When I disable the secrets engine, I got the following:
% vault secrets disable artifactory
Success! Disabled the secrets engine (if it existed) at: artifactory/
And the auth token in Artifactory still exists so I'm pretty sure it has not been revoked.
@TJM I have not able to find any way to intercept the unmount event. The closest I find is the clean
function but that gets called on plugin exists. Not just on unmount.
Therefore, I am not seeing a way to automatically revoke the auth token on unmount at this point. I am closing this ticket but feel free to reopen if you learn something new.
from vault-plugin-secrets-artifactory.
Related Issues (20)
- Verification Steps: Signature on GPG Key? HOT 9
- Scoped down tokens from artifactory role HOT 8
- revoke not working HOT 18
- Add Examples (was: filename in release) HOT 7
- dev version suggestion HOT 4
- slashes in admin token username shows wrong username HOT 1
- Allow for "username" parameter on /config/rotate to change token username HOT 1
- make acceptance uses inconsistent env variables HOT 2
- Test Coverage Improvement
- Bump version to 1.0.0 HOT 2
- Renaming repository HOT 4
- GPG Signed *binary* sha256sums in release HOT 5
- Future Makefile ideas
- Embed current version changes (like from the changelog) in release HOT 1
- DELETE artifactory/config/admin should revoke its own access token HOT 7
- Should DELETE artifactory/config/admin cleanup all leased tokens? HOT 3
- BATs acceptance tests? HOT 2
- Add User-Agent string to Artifactory API HTTP request header
- useExpiringTokens should be TypeBool
- test: config/rotate with a bad current token returns the wrong error
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vault-plugin-secrets-artifactory.