local manifest about docker-lineageos HOT 5 CLOSED

Hi there! Sorry for the late reply but I was out of office last week.

1. What do you think of adding extra environment variables to default.env for adding a local manifest as part of the init process?

I think that is a good idea and quite easy to add! I guess the default would be no manifest?

Are you moving forward with the PR?

2. I see that in the init function you don't call the sync function any reason for not doing it?

Mmm, isn't this it?

from docker-lineageos.

Hi there! Sorry for the late reply but I was out of office last week.

1. What do you think of adding extra environment variables to default.env for adding a local manifest as part of the init process?

I think that is a good idea and quite easy to add! I guess the default would be no manifest?

Are you moving forward with the PR?

Just created a pull request.

1. I see that in the init function you don't call the sync function any reason for not doing it?

Mmm, isn't this it?

Yes, I meant why not call sync function from the line you referenced?

from docker-lineageos.

Oh I see ... that looks like a good idea also :) Do you mind PRing that change as well?

Thank you!

from docker-lineageos.

Done!

from docker-lineageos.

Thank you for the PRs! Merged and building new images 👍

from docker-lineageos.