Git Product home page Git Product logo

Comments (8)

wwwil avatar wwwil commented on May 25, 2024

/assign @wwwil

from jetstack-secure.

AkvileMar avatar AkvileMar commented on May 25, 2024

it's ready for a review.

from jetstack-secure.

j-fuentes avatar j-fuentes commented on May 25, 2024

This is the related PR: #82

from jetstack-secure.

AkvileMar avatar AkvileMar commented on May 25, 2024

Pull requests are ready to go. It should be merged by the end of today.

from jetstack-secure.

wwwil avatar wwwil commented on May 25, 2024

Yesterday @j-fuentes PRs #105 and #106 were merged. My PR #107 was merged and planning to finish #104 today.

from jetstack-secure.

wwwil avatar wwwil commented on May 25, 2024

#104 has been merged, #112 is waiting for review.

#112 tidies up the config loading in check.go but does not fully resolve this issue.

from jetstack-secure.

j-fuentes avatar j-fuentes commented on May 25, 2024

@wwwil what is missing after #112?

I think it is not worth investing more in this since we are going to transition to the agent soon.

from jetstack-secure.

wwwil avatar wwwil commented on May 25, 2024

We're still decoding the config from file field by field, rather than unmarshalling directly into a struct.

But I agree that it's not really worth spending more time on this now.

from jetstack-secure.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.