Keywords: run, onerror, onsuccess, onstart should create new context about snakecharm HOT 7 OPEN

A function context to be precise, so that return isn’t flagged as syntax error

from snakecharm.

@flying-sheep By the way what is return semantics here? The rule fails if run returns False?

from snakecharm.

no idea! but if you return without creating the files you said you would, won’t snakemake catch that anyway?

from snakecharm.

Current behaviour:
'return' outside of function error in all 5 cases:

from snakecharm.

Now now error on return statements, but python control flow isn't snakemake aware and thus gives false positive unreachable code errors

from snakecharm.

• Enable PyUnreachableCodeInspection in SnakemakeVisitorFilter after #14 has been fixed
• Put back ScopeOwner after #119 has been fixed

from snakecharm.

Seems #101 not needed if control flow builder works ok, should smth like 'unbound local variable' exception. Or #101 could be reimplemented using control flow.

from snakecharm.