Comments (5)
Hi, thanks for the detailed issue and apologies for you having to encounter it.
I don't have an environment to hand to verify this (it only needs the ESDB config from the docker-compose config in this repo), but 99% sure this got broken in the TaskSeq port recently (code with async
got changed to task
, and there are variances regarding how the various await mechanisms wrap exceptions). I'd be surprised if it's an ESDB Client or Server issue.
Most likely the test suite is failing too (if it's not, then it should definitely cover this case).
Would definitely appreciate a PR - can get a fresh nuget released right away after that
from equinox.
Hi @bartelink! Thanks for the quick response. I just tried running the test suite for esdb (StoreIntegration.fs is the one right?) and indeed, it fails.
Yep looks like you are right, it's because of the TaskSeq port. Removing the wrapping of the exception fixes the issue and all tests pass :) I'll provide a PR. A new nuget release would be awesome!
from equinox.
Excellent, thank you!
Need to go afk now; will review the PR in full later
Main thing that sticks out for now is that I'd prefer to stick with the = thtask {
on the previous line as per the rest of the repo - I appreciate that's non-standard, but mixing styles is even worse ;)
(If you'd prefer for me to apply style tweaks myself afterwards, rather than doing a to/fro exercise, let me know either)
from equinox.
Yes fully agree with you! Mixing code styles is a nightmare :D
Do you have a "formatting/style guide" file that I can plug into my IDE by any chance?
Changed it by hand now but usually I let my IDE format the code for me.
from equinox.
Unfortunately the code formatting is mainly manual. There is a .editorconfig
(which is very sparse) - open to improvements on that but in general the aim would be to have any proposed rules immediately be consistently applied, which makes it a non-trivial task. In general the = task {
on the previous line (and closing brace on last line) is the key thing that deviates from typical conventions in the F# style guide.
Einar took a run at applying Fantomas in #345 - that might be more viable had it [existed and] been used from the start - in general its rules would likely encourage pulling out more helpers etc
from equinox.
Related Issues (20)
- V2: constrain dependencies HOT 1
- V2: Cosmos: Backport LogSink signature change HOT 2
- QUESTION: How do you support regulatory requirements to purge persisted Personally Data (e.g. GDPR)? HOT 4
- Cosmos Table support HOT 2
- Cosmos: Fix unfold event numbering
- The canonical definition of AwaitTaskCorrect is incorrect HOT 4
- Add LoadOption.RequireLeader
- missed published packages HOT 6
- StreamId.gen2/3 - consider revert to struct tuples HOT 1
- Is there a specific message-db version that one has to use? HOT 8
- DynamoDB: EventsContext fails to read when tip not read HOT 1
- Feature: ReadThrough mode HOT 1
- DynamoStore: Needs to write through tip to guarantee order on DDB streams
- Core: NullReferenceException when using cached reads
- DynamoStore: Use ReturnValuesOnConditionCheckFailure to implement Resync
- refactor: Label contexts unambiguously
- Rename AsyncCacheCell to TaskCell
- CosmosStore: Complain about large partition keys if not configured
- Remove Compaction from Domain terms
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from equinox.