No way to use django variables in the attrubute consitently. about hamlpy HOT 5 CLOSED

I had a commit (0e53ea2) that allowed
#blah{'class':=minor}
which would then be converted into
#blah{'class':'{{minor}}'}
and then into
<div id="blah" class="{{minor}}">

It was just a simplistic find and replace, so it led to issues with code like
%a{"href":"{% url foo.bar param=object.value %}"}

The underlying issue in the codebase is that the attribute dictionary is parsed as a python dictionary by calling eval on the string. While that is very powerful and allows for a lot of complexity, it makes it difficult to change the parsing of the string. My commit used a simple regular expression to find variables prefixed with = to convert, but that's really not a robust approach.

To implement a better way of specifying django variables the parsing of attributes would need to either be handled by using lower level python parsing than eval (http://docs.python.org/library/parser.html) or rolling a parser for just attributes. Both are a lot of work for what amounts to a smarter way to add '{{ }}' around variables, but a cynic could describe HAML as just a lot of work for what amounts to a smarter way to add closing tags.

from hamlpy.

What is the right way to write this?

%img{'src':item.product.images.0.link}

from hamlpy.

%img{'src':'{{item.product.images.0.link}}'} will work

from hamlpy.

Yes that works! Thank you.

from hamlpy.

from hamlpy.