Comments (6)
I suppose, but really you'd have to be insane to type that and expect a good result. What's happening here, as you know, is that you are creating a new roots project called the name of the current folder. So it makes sense that it would overwrite the current folder with the new roots project. I can manually prevent the user from entering .
or ..
as the name, would that help?
from roots.
hmm we could just throw a warning @Jenius like are you sure bro?
from roots.
@Jenius Overwriting is fine, but not deleting everything in that folder, same goes for (roots new ./project). Root should only delete its own files. Here is user-case:
I was experimenting with deployd. Created new project with dpd init
, then noticed I have empty public folder. Great let's try roots, roots new .
puff. Everything gone (package.json,.git...) you get the point, how bad it is to delete everything. Also because command deletes folder and creates new, bash complained it lost pwd handle o.O.
from roots.
I also expect roots new app
to write its files, overwriting them if they already exist, but not delete the whole directory. As @samccone said, it should at least warn the user.
from roots.
ok @dz0ny and @Kazy thanks for the feedback, this should fix it 💃
from roots.
closing it now that is has been merged
from roots.
Related Issues (20)
- Npm warning when installing Roots globally ([email protected])
- Npm warning when initializing new Roots project ([email protected]) HOT 1
- Confused about `ignores` and `dump_dirs` configuration options HOT 5
- v1.roots.cx 500 Internal Server Error HOT 10
- Compile only "changed files" from watch command HOT 3
- watch command changes file names HOT 3
- Can't get handlebars.js to work HOT 3
- Make analytics opt-in HOT 3
- Installation not working on Mac OSX HOT 9
- Roots error when installing globally HOT 3
- Roots fails to run after install HOT 1
- Official nodejs Docker images need to be rewritten to support roots HOT 1
- use js rather than coffee HOT 2
- Public folder created outside root directory HOT 1
- Before Hook Promise HOT 3
- Axis Bold as Love HOT 1
- error fatal: Could not read from remote repository. HOT 1
- Roots won't install HOT 1
- Roots JS-API Use Coffeescript.register() error HOT 1
- Roots watch uses app.production.coffee HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from roots.