Git Product home page Git Product logo

Comments (7)

samccone avatar samccone commented on July 18, 2024

hmmm i would say leave this up to the dev to code their CSS / JS correctly

from roots.

jescalan avatar jescalan commented on July 18, 2024

Sure, i just want to make it available as a mixin, for convenience, if they want. It could just grab the parent background property, add @2x to the url, then get the width and height and set those as background-size. Ya know?

from roots.

samccone avatar samccone commented on July 18, 2024

meh... the 2x thing is just a practice that some people use... i think there are better ways to do it .. but that is it .. it is a preference on a case by case basis.

but if it is a mixin then i see no harm

from roots.

jescalan avatar jescalan commented on July 18, 2024

That's definitely true, although I'd classify the @2x more as a convention at the point than a practice that some people use. I know you've been working a lot of responsive stuff lately though - how have you been doing it? Is there any kind of mixin functionality you'd put on your wishlist?

from roots.

samccone avatar samccone commented on July 18, 2024

ha,

SVG with modernizer png fallback all the way .. 2X is a broken model because the first 2.5 pixel density screen will completely break 2X sites

from roots.

jescalan avatar jescalan commented on July 18, 2024

solid point. you've used this more than me, can you think of any shortcuts that would make this easier/automatic?

from roots.

jescalan avatar jescalan commented on July 18, 2024

This has been added to root-css as bg-retina(). I'd still like to build out a mechanism to incorporate your svg method, but that will happen down the road.

from roots.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.