Git Product home page Git Product logo

Comments (7)

jeremyramin avatar jeremyramin commented on August 15, 2024

I see what you're saying. I can have the terminal resize smaller with the window but at then at a certain point you reach the minimum terminal height. Does that sound good?

from terminal-plus.

lijunle avatar lijunle commented on August 15, 2024

How do you determine the minimun height? You hard code it, or calculate it dynamically on the fly?

from terminal-plus.

jeremyramin avatar jeremyramin commented on August 15, 2024

Calculate it dynamically. I could have the terminal resize down with Atom past the usual minimum of three lines. However I think that the terminal should at least show three lines for displaying command output.

from terminal-plus.

lijunle avatar lijunle commented on August 15, 2024

IMO, it could better not to do such assumption. We don't know where do Atom running. Just think about user are running on a mobile phone and not having enough room to show three lines.

By the way, why not make terminal a real Atom panel and let Atom to handle this kind od resizing?

from terminal-plus.

jeremyramin avatar jeremyramin commented on August 15, 2024

The terminal is attached as a real Atom bottom-panel. Atom does not handle the resizing of the bottom panels. If you try resizing Atom smaller without the terminal, you'll see that the Atom status-bar begins to disappear at some point. This is why the best I can do is track the window resizing and have the terminal resize smaller with Atom.

from terminal-plus.

jeremyramin avatar jeremyramin commented on August 15, 2024

The latest release (v0.6.0) should have the resizing to Atom window. Hopefully it is designed as you requested.

from terminal-plus.

lijunle avatar lijunle commented on August 15, 2024

Thanks @jeremyramin , the fix is awesome! πŸ‘

from terminal-plus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.