Add content-type to plugin: json about roda HOT 8 CLOSED

@Kyrremann how did you solve it at the end?

from roda.

I've solved it by adding the content-type to all my outgoing calls.
See here: https://github.com/Kyrremann/TagStoryApi/blob/master/routes/v1.rb

from roda.

Ahh, Thanks! I did the same! 👍

from roda.

Maybe the json plugin could allow the Content-Type to be configured, instead of having "application/json" hardcoded. I'm for example using this plugin to do serialization of records (the plugin allows you to easily make your own serialization which can be anything), and maybe (god forbid) I would need to return XML, in which case it would be useful to be able to set "application/xml". The plugin is named "json", but since it already supports custom serializers, it would be cool if it also supported custom Content-Type (preferrably dynamic, so that it can for example be different depending on the "Accept" request header).

from roda.

I'm fine with allowing customization of the content type, can someone submit a pull request for it?

from roda.

I'm working on a small Pull Request, but I'm not sure what you meant by dynamic content-type.

from roda.

If you're serializing records, an often use case is that you allow different formats to be returned (JSON, XML, CSV etc), so I thought it would be nice that this plugin is also able to set the Content-Type header depending on the request (if a user requests this resource in JSON format, set "application/json", if other user requests this resource in XML, set "application/xml", and so on).

However, I think a better idea is that the plugin sets the Content-Type only if it's not already set (just by using ||= instead of =), so that users are rather able to set the Content-Type manually, without the plugin overriding it. That's solves it perfectly, I think.

But I see now that this is a separate change, so you just continue with your PR, I might make a PR for this afterwards :)

from roda.

I've made a Pull Request now, so please take a look #58.
I went for the more elaborated way where you need to set the content-type as an option for the plugin, instead of just setting the content-type if it's not already set (see the last comment).
I think this is best as it makes it more explicit.

from roda.