Git Product home page Git Product logo

Comments (4)

xfudox avatar xfudox commented on June 13, 2024

So this is it? No questions, no answer, just close my issue?

from date.

jenssegers avatar jenssegers commented on June 13, 2024

I don't think this is an issue anymore in the latest release. Have you updated already?

from date.

kylekatarnls avatar kylekatarnls commented on June 13, 2024

@xfudox those deprecations are handled. Carbon 2 supports:

"symfony/translation": "^3.4 || ^4.0 || ^5.0"

%count% is not supported in 3.4 so we're forced to use transChoice() for 3.x and which is the method cross-compatible among versions from 3 to 5. And since 4.2 transChoice is deprecated (you're using Symfony > 4.2 <5 I guess).

And in Symfony 5, it's removed and we use ->trans() when ->transChoise() is not available.

In Carbon 3, we won't support Symfony < 5 anymore.

As you can see the deprecation is perfectly handled (we will never fall in the case where Carbon is using a removed method, which is what the deprecation notice is there to avoid). What you should do is migrate to Symfony 5. But if you don't want to. It's fine to stay on Symfony 4 and those deprecation actually are not a problem at all for you, because it's not up to you to handle them.

from date.

kylekatarnls avatar kylekatarnls commented on June 13, 2024

I insist about this point: deprecations are not errors you should handle in a fast or mandatory way. A deprecated method (if the library owner correctly used deprecation) is still supposed to works as before and as expected. It just tells you: it will no longer exist in the future (a precise version if specified, or else you can assume it disappear on the next major version). Then the deprecation often propose an alternative that would help you to migrate later in an easier way. So you can follow the deprecation advice to anticipate a possible future migration and so be ready already.

But you could still ignore every deprecation and handle them only when you actually upgrade. At this moment, then the doc, changelog or migration guide of the given library would tell you "foobar method is removed", which would no longer trigger a notice but a fatal error. Then it would still not be too late to replace the method according to the migration guide and you would be all fine.

from date.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.