Git Product home page Git Product logo

Comments (2)

jensl avatar jensl commented on August 29, 2024

Yes, this is an issue. You can usually always use the [reviewable], [relevant] or [full] filters to look at all changes in the review (filtered in different ways to only show some of the modified files.) In the view they produce, you effectively look at the diff between the current tip of the review branch and the "upstream commit," but you can still mark changes as reviewed, which marks them as reviewed in the original commits in the review.

It doesn't work in some cases, but I think that's mostly when you push irregular merges to the review (merging in a commit that is not a descendant of the review branch's "upstream commit.")

The reason you can't mark changes as reviewed when you look at commits in the "actual log" is that it's not easy to map that back to the original commits. It works in the [reviewable], [relevant] and [full] filter cases because they show all changes, and mapping "all rebased changes" to "all original changes" is safe.

One way to avoid it would be to let the rebased commits replace the original commits in the review when the review is rebased, but that becomes really tricky if the original commits are partially reviewed, since there may not be any obvious way to translate that partial state onto the new commits.

from critic.

jadahl avatar jadahl commented on August 29, 2024

I didn't know about theh [reviewable] etc, which covers most of the use cases I was looking for.

Maybe some other of the use cases I had in mind (being able to select commits over a rebase) could be solved similar to [reviewable] but only for the selected commits (or their corresponding rebased commit).

Anyhow, you can consider this a low priority as far as I'm concerned, as [reviewable] addresses most of my use cases I was looking for.

from critic.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.