Git Product home page Git Product logo

Comments (7)

stephenashank avatar stephenashank commented on June 30, 2024

@Casz Thanks for pointing this out. Is this a situation where it would be appropriate to blacklist the 0.8 release after releasing this fix?

from google-oauth-plugin.

jetersen avatar jetersen commented on June 30, 2024

it could be: see jenkins-infra/update-center2#263 for an example of this 😓

from google-oauth-plugin.

stephenashank avatar stephenashank commented on June 30, 2024

Can you explain the utility/security that this provides over an invisible entry? We already don't render these keys, and it is still possible to view the encoded secret with secretTextarea through inspect element.

from google-oauth-plugin.

stephenashank avatar stephenashank commented on June 30, 2024

The one use I could see would be directly inputting a secret without uploading a file

from google-oauth-plugin.

jetersen avatar jetersen commented on June 30, 2024

Ya, it is meant for direct key entries, sorry if that wasn't clear 👍

from google-oauth-plugin.

jetersen avatar jetersen commented on June 30, 2024

See screenshots at jenkinsci/jenkins#3967

from google-oauth-plugin.

stephenashank avatar stephenashank commented on June 30, 2024

Thanks for clarifying, I'm glad this is a feature request and not a security concern.

Support for direct input would be interesting, although I think it might require more thinking into how to integrate that with the existing file upload UI elements.

from google-oauth-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.