Comments (14)
DavidTanner
commented on July 21, 2024
Did the build ever start? Once the status changes to "Build Started, sha1 is merged" you should get a link.
from ghprb-plugin.
leandro-lucarella-sociomantic
commented on July 21, 2024
Yeah, the build are starting and finishing. I get the comments posted by ghprb, the commit status is the one not being updated. I even have the option to only comment when setting the status fails, so it might be that updating the statuses is failing for some reason, because I always get the comments instead.
from ghprb-plugin.
DavidTanner
commented on July 21, 2024
Are there errors in the system logs?
from ghprb-plugin.
DavidTanner
commented on July 21, 2024
The error is that the context is an empty string. I will fix it and release 1.22.1. The context either has to have something in it, or be null.
from ghprb-plugin.
leandro-lucarella-sociomantic
commented on July 21, 2024
I have a logger configured to log org.jenkinsci.plugins.ghprb, this is what I see:
Jun 01, 2015 6:06:36 PM INFO org.jenkinsci.plugins.ghprb.GhprbRootAction doIndex
Checking issue comment 'org.kohsuke.github.GHIssueComment@425883dd' for repo some/repo
Jun 01, 2015 6:06:36 PM FINER org.jenkinsci.plugins.ghprb.GhprbRepository
Comment on issue #679 from User:leandro-lucarella-sociomantic: test this please jenkins
Jun 01, 2015 6:06:36 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Retest phrase
Jun 01, 2015 6:06:36 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Retest accepted and user User:leandro-lucarella-sociomantic is whitelisted
Jun 01, 2015 6:06:36 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Running the build
Jun 01, 2015 6:06:36 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
PR is not null, checking if mergable
Jun 01, 2015 6:06:37 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Running build...
Jun 01, 2015 6:07:30 PM INFO org.jenkinsci.plugins.ghprb.GhprbRepository commentOnFailure
Trying to send comment.
org.jenkinsci.plugins.ghprb.extensions.GhprbCommitStatusException: Build finished.
at org.jenkinsci.plugins.ghprb.extensions.status.GhprbSimpleStatus.createCommitStatus(GhprbSimpleStatus.java:88)
at org.jenkinsci.plugins.ghprb.extensions.status.GhprbSimpleStatus.onBuildComplete(GhprbSimpleStatus.java:75)
at org.jenkinsci.plugins.ghprb.GhprbBuilds.onCompleted(GhprbBuilds.java:122)
at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:27)
at org.jenkinsci.plugins.ghprb.GhprbBuildListener.onCompleted(GhprbBuildListener.java:12)
at hudson.model.listeners.RunListener.fireCompleted(RunListener.java:199)
at hudson.model.Run.execute(Run.java:1786)
at hudson.matrix.MatrixBuild.run(MatrixBuild.java:306)
at hudson.model.ResourceController.execute(ResourceController.java:98)
at hudson.model.Executor.run(Executor.java:374)
from ghprb-plugin.
leandro-lucarella-sociomantic
commented on July 21, 2024
Another one without a traceback (I've been playing with different settings adding or removing the messages, so maybe this is what it changed).
Jun 01, 2015 6:30:03 PM INFO org.jenkinsci.plugins.ghprb.GhprbRootAction doIndex
Got payload event: pull_request
Jun 01, 2015 6:30:03 PM INFO org.jenkinsci.plugins.ghprb.GhprbRootAction doIndex
Checking PR #679 for some/proj
Jun 01, 2015 6:30:03 PM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest check
Pull request #679 was updated on some/proj at 6/1/15 6:29 PM by User:leandro-lucarella-sociomantic
Jun 01, 2015 6:30:04 PM FINE org.jenkinsci.plugins.ghprb.GhprbPullRequest
New commit. Sha: a468a450c8704fbfcb7cdab0e99df91212f248eb => 86d90203c53fb91b22ccd9e88b43a6f16cbfaf25
Jun 01, 2015 6:30:04 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Running the build
Jun 01, 2015 6:30:04 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
PR is not null, checking if mergable
Jun 01, 2015 6:30:04 PM FINEST org.jenkinsci.plugins.ghprb.GhprbPullRequest
Running build...
Jun 01, 2015 6:30:37 PM SEVERE org.jenkinsci.plugins.ghprb.GhprbRepository commentOnFailure
Could not update commit status of the Pull Request on GitHub.
Jun 01, 2015 6:30:37 PM SEVERE org.jenkinsci.plugins.ghprb.GhprbRepository commentOnFailure
Could not update commit status of the Pull Request on GitHub.
Jun 01, 2015 6:30:37 PM INFO org.jenkinsci.plugins.ghprb.GhprbRootAction doIndex
Got payload event: issue_comment
Jun 01, 2015 6:30:37 PM INFO org.jenkinsci.plugins.ghprb.GhprbRootAction doIndex
Checking issue comment 'org.kohsuke.github.GHIssueComment@5cda8984' for repo some/proj
Jun 01, 2015 6:30:37 PM FINER org.jenkinsci.plugins.ghprb.GhprbRepository
Comment on issue #679 from User:github-admin-sociomantic:
Refer to this link for build results (access rights to CI server needed):
https://jenkins/job/core-team/job/proj-pr/1384/
Jun 01, 2015 6:31:32 PM SEVERE org.jenkinsci.plugins.ghprb.GhprbRepository commentOnFailure
Could not update commit status of the Pull Request on GitHub.
Jun 01, 2015 6:31:33 PM INFO org.jenkinsci.plugins.ghprb.GhprbRootAction doIndex
Got payload event: issue_comment
Jun 01, 2015 6:31:33 PM INFO org.jenkinsci.plugins.ghprb.GhprbRootAction doIndex
Checking issue comment 'org.kohsuke.github.GHIssueComment@2e49882f' for repo some/proj
Jun 01, 2015 6:31:33 PM FINER org.jenkinsci.plugins.ghprb.GhprbRepository
Comment on issue #679 from User:github-admin-sociomantic:
Refer to this link for build results (access rights to CI server needed):
https://jenkins//job/core-team/job/proj-pr/1385/
from ghprb-plugin.
leandro-lucarella-sociomantic
commented on July 21, 2024
Also, I noticed that adding the action to change the context, doesn't really change the context in the commit status (not a big problem to me, I wasn't using that, I just played with it while trying to make this work :).
from ghprb-plugin.
leandro-lucarella-sociomantic
commented on July 21, 2024
Oh, I just noticed you already found and fixed the issue (hopefully)! Thanks for the very quick response!
from ghprb-plugin.
DavidTanner
commented on July 21, 2024
If you set the context in the job then the commit status would be updated. Changing the context in the main configuration just sets a default for each job to use.
from ghprb-plugin.
DavidTanner
commented on July 21, 2024
The new version has been released, but it will take a few hours for it to show up in the update center.
from ghprb-plugin.
leandro-lucarella-sociomantic
commented on July 21, 2024
I used a context and it still failed to set the commit status after the initial "Build triggered. sha1 is merged." status. The context was always set to "default" (it doesn't matter if I defined in the ghprb config or not). This is at least what I see if I query the commit status for the merge commit using the github API.
from ghprb-plugin.
leandro-lucarella-sociomantic
commented on July 21, 2024
For now I downgraded to v1.21.1, tomorrow I'll try to give the new version a shot, but briefly because I leave for vacations for a week, and I must leave a working pull request tester in jenkins :)
Anyway, thanks again for the quick answer!
from ghprb-plugin.
DavidTanner
commented on July 21, 2024
There should also be useable stacks in the logs in the next version.
from ghprb-plugin.
leandro-lucarella-sociomantic
commented on July 21, 2024
v1.22.1 seems to be working fine, thanks!
from ghprb-plugin.
Related Issues (20)
- Unable to connect to GitHub HOT 2
- Worker nodes aren't started when pipeline requests to run parallel parts on same node
- Log4j in ghprb? HOT 1
- Trigger based on directories HOT 1
- Pull request approval without fetch
- usage of org-list may incur github rate limit
- Publish multiple github-statuses from the same pipeline job HOT 1
- ${ghprbActualCommit} does not pick up current commit from hook if an additional branch is specified. HOT 2
- Create new pull request with a comments,but not be triggered. Comment a gain and reopen the pull request,then be triggered
- Restrict Specific branch for Pull request
- What kind of "actions" does the Pull request Webhook of the Github pull request builder support?
- What kind of "actions" does the Pull request Webhook of the Github pull request builder support? HOT 1
- Plug-in Question
- Changing the status context (name) in the config while a job is running leaves the old status in pending forever
- Changing(rotating) plugin credentials take no effect until Jenkins is restarted due to cached repo object
- Is this plugin is not maintained anymore? if so, is there any alternative plugin for it ? HOT 1
- Can Help WIth Plugin Upgrade
- Warning: The currently installed plugin version may not be safe to use. Please review the following security notices:
- Not able to trigger jenkins job by adding specific labels
- When A PR is not mergeable the Github status check does not get updated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ghprb-plugin.